WordPress.org

Make WordPress Core

#42664 closed defect (bug) (fixed)

Editor link autocomplete suggestions: no fallback title displayed for posts with no title

Reported by: afercia Owned by: afercia
Milestone: 4.9.2 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-screenshots has-patch fixed-major
Focuses: Cc:

Description

When inserting a link in a post, the links suggestions list doesn't show any fallback title for posts with no title. There's just an empty space followed by the post date:

https://cldup.com/zjJ4pdkTyA.png

Worth noting the "Link options" modal does display a fallback title for that same post, and it's the string (no title) already used in other places in core:

https://cldup.com/Y54vX9842z.png

Attachments (1)

42664.diff (897 bytes) - added by afercia 21 months ago.

Download all attachments as: .zip

Change History (8)

@afercia
21 months ago

#1 @afercia
21 months ago

  • Keywords has-patch added; needs-patch removed

42664.diff is a first pass, I guess it is necessary to check for window.wpLinkL10n as that check is done in other parts too, but I'm not so sure why. Any feedback welcome.

Last edited 20 months ago by afercia (previous) (diff)

#2 @afercia
21 months ago

  • Owner set to afercia
  • Status changed from new to assigned

#3 @johnbillion
21 months ago

  • Milestone changed from 4.9.1 to 5.0

#4 @afercia
20 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42425:

Editor: Link suggestions: add fallback title for posts with no title.

Fixes #42664.

#5 @afercia
20 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.0 to 4.9.2

Reopening for 4.9.2 consideration.

#6 @afercia
20 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @SergeyBiryukov
20 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42439:

Editor: Link suggestions: add fallback title for posts with no title.

Props afercia.
Merges [42425] to the 4.9 branch.
Fixes #42664.

Note: See TracTickets for help on using tickets.