Dynamic Hooks that use REQUEST / GET / POST variables

[ramiy]

The background for this ticket is naming-convention for ​dynamic hooks set in ticket #37748 and in the ​Coding Standards Best Practices.

WordPress core has ​5 hooks that don't implement those best practices, hooks that use $_REQUEST, $_GET and $_POST variables as parameters in their names.

---

The attached patch fixes those hooks, replacing:

do_action( 'network_admin_edit_' . $_GET['action'] );

with:

do_action( "network_admin_edit_{$action}" );

---

Note that the change has other benefits like affecting the code reference slugs:

• ​https://developer.wordpress.org/reference/hooks/wp_ajax__requestaction/
• ​https://developer.wordpress.org/reference/hooks/admin_action__requestaction/
• ​https://developer.wordpress.org/reference/hooks/network_admin_edit__getaction/
• ​https://developer.wordpress.org/reference/hooks/wp_ajax_nopriv__requestaction/
• ​https://developer.wordpress.org/reference/hooks/network_sites_updated_message__getupdated/

[ramiy]

@DrewAPicture please review the ticket and the attached patch.

[DrewAPicture]

@ramiy So, the patch is a good start, except that the new $action initializations against superglobals need to check if they're set before assigning the value, defaulting to an empty string otherwise.

[ramiy]

@DrewAPicture Currently we don't check if super-globals are set, but I added isset() checks to the patch.

[DrewAPicture]

In 42349:

Hooks: Standardize naming of dynamic hooks using values derived from superglobals to use interpolation vs concatenation.

This is a continuation of the work that happened in [38307] for #37748.

Props ramiy.
Fixes #42698.