Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#42708 closed enhancement (worksforme)

editor offers to add required protocol - http or https?

Reported by: pixelverbieger's profile pixelverbieger Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: TinyMCE Keywords:
Focuses: Cc:

Description

class-wp-editor.php:1140 contains a string asking if "the required http:// prefix" should be added to a (presumable) external link.

Does this add only http or https or any of them, depending on the used protocol of the website?
Shoud the wording (and thus the translation) be adjusted?

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-editor.php?marks=1140#L1140

Change History (2)

#1 @Presskopp
6 years ago

What is to do to bring this up? Seems related to Link Plugin, but still I can't see it anywhere..

#2 @azaozz
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

This seems to be for the "native" TinyMCE link modal which is not used in WP by default. I'm assuming it offers to add http only to URLs that were typed by hand and are presumed external as this is still the most common protocol. Most sites that are on https will happily redirect the user to it.

Note that this has nothing to do with the site's protocol.

Going to close this as worksforme as it seems the current behavior makes most sense. In any case it is part of TinyMCE and has to be changed upstream.

Note: See TracTickets for help on using tickets.