Permit use of 'text-transform' in safecss_filter_attr()

[danielbachhuber]

As a WordPress user, I'd expect that whitelisting use of the style attribute for <span> elements would permit use of text-transform:lowercase; within the attribute.

However, doing so also requires filtering safe_style_css. Given text-transform is a text formatting property like font-style and text-decoration, it makes sense to also include it in safecss_filter_attr()'s default property set.

[juiiee8487]

I have created patch to whitelist text-transform CSS property.

[juiiee8487]

I have created patch 42729.diff to whitelist text-transform CSS property.

[DrewAPicture]

Hi @juiiee8487, thanks for the patch! I've assigned this good-first-bug ticket to you to mark it as "claimed" and somebody should be along to review your patch and give you some feedback on next steps. Sorry for the delay in response.

[juiiee8487]

Hi @DrewAPicture, No problem! and Thank you! I am happy to own first ticket :)

[birgire]

The patch in 42729.diff​ looks good.

There are currently no explicit tests for the safecss_filter_attr() function.

The patch in 42729.2.diff​

• adds @since in the docblock of the safecss_filter_attr() function.
• adds tests for the safecss_filter_attr() function with a data provider.

There's a suggested patch by @joehoyle in #24157 for tests, that we could also consider.

But it looks like that patch is blocked by the discussion of allowing parentheses.

[SergeyBiryukov]

In 42880:

Formatting: Permit use of text-transform in safecss_filter_attr().

Add unit tests for safecss_filter_attr().

Props birgire, juiiee8487, danielbachhuber.
Fixes #42729.

[johnbillion]

[42880] should be merged into 5.0. @since needs updating.

[pento]

Gutenberg doesn't need text-transform, so I'm bumping this to 5.1. The version will still need to be updated.

[desrosj]

In 44531:

Docs: Update since annotation for text-transform support in safecss_filter_attr().

Introduced in [42880].

Fixes #42729.