Add a has_errors() method to WP_Error

[DrewAPicture]

We should add a method to easily check whether a WP_Error object contains any errors.

There isn't any one standard way to perform such an operation, and in fact, a cursory search of core yielded a variety of methods for checking whether there are any errors in the object, but nothing really consistent:

• Checking empty() on the $errors property
• Checking if the count from get_error_codes() is greater than 0
• Checking if the value of get_error_code() is an empty string

My proposal would be to introduce a boolean has_errors() method, or perhaps empty() that simply checks whether the $errors property is empty or not.

[DrewAPicture]

WP_Error full tests coverage

[DrewAPicture]

In 42255:

General: Add complete test coverage for WP_Error.

See #42742.

[robdxw]

Add has_errors() method and tests

[robdxw]

I've submitted a patch adding the has_errors() method & tests. This is my first patch, so please let me know if anything needs changing.

[SergeyBiryukov]

Hi @robdxw, thanks for the patch! It looks good to me.

As a next step, we could update all the instances in WordPress core that currently check if a WP_Error object contains any errors in one way or another (as outlined in the ticket description) to use the new method instead.

[DrewAPicture]

In 42646:

Tests: Simplify @covers annotations for WP_Error test coverage. Also fix a typo in a test method name.

See #42742.

[DrewAPicture]

42742.diff​ just updates @robdxw's latest patch to fix the simplified @covers annotations introduced in [42646].

Also assigns the ticket to @robdxw to mark the good-first-bug as "claimed".

[SergeyBiryukov]

In 42761:

General: Introduce WP_Error::has_errors() method and use it where appropriate.

Props robdxw, DrewAPicture, SergeyBiryukov.
Fixes #42742.

[johnbillion]

@since needs updating

[desrosj]

In 44527:

Docs: Update since annotations WP_Error::has_errors()

Introduced in [42761].

Fixes #42742.

[desrosj]

This was mentioned in a 5.1 dev note: ​https://make.wordpress.org/core/2019/01/23/miscellaneous-developer-focused-changes-in-5-1/