WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#42744 closed defect (bug) (wontfix)

Need to Modify Radio & Checkbox Label Class

Reported by: santai89 Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: reporter-feedback
Focuses: Cc:

Description

Radio and Checkbox label are shifted left,unable to click.Required to add margin-left: 24px; in .customize-control-checkbox label and .customize-control-radio label class in customize-control.css.

Attachments (2)

customizer_previous_ver4.8.png (108.7 KB) - added by santai89 2 years ago.
customizer_current_ver4.9.png (127.8 KB) - added by santai89 2 years ago.

Download all attachments as: .zip

Change History (8)

#1 follow-up: @westonruter
2 years ago

  • Keywords reporter-feedback added

@santai89 please add a screenshot. Are these inputs in core or part of a theme/plugin? If so, which one?

#2 in reply to: ↑ 1 ; follow-up: @santai89
2 years ago

Replying to westonruter:

@santai89 please add a screenshot. Are these inputs in core or part of a theme/plugin? If so, which one?

Hi westonruter,

Inputs are developed by theme(http://wp.nootheme.com/?theme=jobmonster) through extending WP_Customize_Control class. In the previous version of wordpress .customize-control-checkbox label and .customize-control-radio label was the css style margin-left: 24px;.Current version it was removed.But in .customize-control-radio input and .customize-control-checkbox input have the style margin-left: -24px; line no 999 in customize-controls.css.So its make problem for this current version of wordpress.I have attach two screenshot of different version.

#3 in reply to: ↑ 2 @santai89
2 years ago

  • Keywords has-patch added

Replying to santai89:

Replying to westonruter:

@santai89 please add a screenshot. Are these inputs in core or part of a theme/plugin? If so, which one?

@westonruter,

Inputs are developed by theme(http://wp.nootheme.com/?theme=jobmonster) through extending WP_Customize_Control class. In the previous version of wordpress .customize-control-checkbox label and .customize-control-radio label was the css style margin-left: 24px;.Current version it was removed.But in .customize-control-radio input and .customize-control-checkbox input have the style margin-left: -24px; line no 999 in customize-controls.css.So its make problem for this current version of wordpress.I have attach two screenshot of different version.

#4 follow-up: @westonruter
2 years ago

  • Keywords has-patch removed

@santai89 please also share the code that is responsible for extending the control.

The structure of radio/checkboxes was updated to make the label a sibling of the checkbox instead of the radio/checkbox's parent element. See r41740 for #33085. There is now a .customize-inside-control-row element that wraps each label and radio/checkbox. If you add the same to your subclass, you'll get the proper styles.

#5 in reply to: ↑ 4 @santai89
2 years ago

Replying to westonruter:

@santai89 please also share the code that is responsible for extending the control.

The structure of radio/checkboxes was updated to make the label a sibling of the checkbox instead of the radio/checkbox's parent element. See r41740 for #33085. There is now a .customize-inside-control-row element that wraps each label and radio/checkbox. If you add the same to your subclass, you'll get the proper styles.

@westonruter
I am go through with your solution and found that it was theme issue.They can not compatible it with latest version of wordpress. I will contact with them for these issue they have.By the way thanks for your suggestion/reply.

#6 @westonruter
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.