Pass $attachment_id to intermediate_image_sizes_advanced filter

[robbie505]

I'm requesting that the following patch be added, which simply passes the $attachment_id of the image to be used for the new post thumbnail sizes to the intermediate_image_sizes_advanced filter in the wp_generate_attachment_metadata function.

The purpose of this is for unsetting intermediate sizes based on conditions for specific images. For example, I have a need for creating large private galleries with thumbnails-only. So to save hosting storage, I could unset several image-sizes in the $sizes array, depending on a post_meta of the $attachment_id.

[johnbillion]

Thanks for the ticket, @robbie505, and welcome to WordPress Trac.

If you're interested in [submitting a patch ​https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/], that would be a big help!

[drywallbmb]

Is the diff I just added what you were hoping for, @robbie505 ?

[drywallbmb]

Oops, that first patch was generated by git without the --no-prefix flag so it won't play nicely with SVN. Uploaded a new patch that should work better. Sorry!

[robbie505]

Yes @drywallbmb that’s exactly what I was looking for!

I’m new to this.. Where do we go from here?

[drywallbmb]

@robbie505 Not sure, TBH. I've developed a bunch of plugins but never contributed to core and thought this ticket would be a reasonable entry point. I think now someone like @johnbillion gets to weigh in...?

[johnbillion]

@drywallbmb Patch looks good! The only thing that needs adding is a @since entry for the parameter. Example: https://core.trac.wordpress.org/browser/tags/4.9.1/src/wp-admin/includes/media.php?marks=2915#L2907

[drywallbmb]

@johnbillion Oh bother! Thanks for catching that.

New patch provided, though I'm not 100% sure I did it right. Specifically, I'm not sure if I should have done 5.0, 5.0.0, or some magic string that will get auto-populated with the release version when it's finally committed to core.

[drywallbmb]

Closer look at existing codebase leads me to the conclusion it should read 5.0.0, updating the patch to reflect that.

[robbie505]

@drywallbmb I noticed other entry's like 3.0.0.
And I bet it needs to be static.

[johnbillion]

Fixed in [42407].

[audrasjb]

Hello,

@johnbillion you closed the ticket as fixed in [42407] (which seems to be right) and you reopened it later. I can't figure why but there is probably a good reason :) What is needed to see this ticket land in 5.0.3?

[johnbillion]

This was fixed in trunk but didn't make it into 5.0. It should be able to go into a minor release soon.

[desrosj]

This one needs a since update. With 5.1 right around the corner, let's leave it out of 5.0.3 since it is not a regression or block editor related fix.

[desrosj]

In 44385:

Docs: Update since tag for new intermediate_image_sizes_advanced filter parameter.

Originally added in [42407].

Fixes #42745.