WordPress.org

Make WordPress Core

Opened 23 months ago

Last modified 9 months ago

#42749 assigned enhancement

Accessibility enhancements for change password field

Reported by: alexstine Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.9
Component: Users Keywords: has-patch needs-refresh
Focuses: accessibility Cc:
PR Number:

Description

Attaching accessibility enhancements to the users.js file which includes support for the change password box. The button is now never hidden and will offer a more accessible experience.

  • Announce when form is open or closed.
  • Focus in form after open.

Hope it's useful.

Attachments (3)

user-profile.js (13.2 KB) - added by alexstine 23 months ago.
Accessibility fixes for users.js.
42749.patch (3.2 KB) - added by alexstine 23 months ago.
users.js
42749-2.patch (3.2 KB) - added by alexstine 23 months ago.
Patch #2. Remove focus on password field.

Download all attachments as: .zip

Change History (16)

@alexstine
23 months ago

Accessibility fixes for users.js.

#1 follow-up: @SergeyBiryukov
23 months ago

  • Keywords needs-patch added

Hi @alexstine, welcome to WordPress Trac! Thanks for the ticket.

Could you create a patch with your changes? Working With Patches tutorial might be helpful.

@alexstine
23 months ago

users.js

#2 in reply to: ↑ 1 @alexstine
23 months ago

  • Focuses multisite removed

I've attached a patch file.

Replying to SergeyBiryukov:

Hi @alexstine, welcome to WordPress Trac! Thanks for the ticket.

Could you create a patch with your changes? Working With Patches tutorial might be helpful.

#3 @SergeyBiryukov
23 months ago

  • Keywords has-patch added; needs-patch removed

#4 @afercia
23 months ago

  • Owner set to afercia
  • Status changed from new to assigned

#5 @alexstine
23 months ago

I have made another patch to exclude focus. I'm attaching it.

@alexstine
23 months ago

Patch #2. Remove focus on password field.

#6 @afercia
23 months ago

I'd second to not move focus programmatically, as it is often just an assumption on a specific workflow. See also #42852 where the attached patch incorporates some of the changes proposed here.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


23 months ago

#8 @afercia
23 months ago

  • Milestone changed from Awaiting Review to 5.0

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


13 months ago

#10 @afercia
12 months ago

  • Owner afercia deleted

#11 @pento
12 months ago

  • Milestone changed from 5.0 to 5.1

#12 @pento
9 months ago

  • Keywords needs-refresh added
  • Milestone changed from 5.1 to Future Release

Patch needs updating.

#13 @afercia
9 months ago

A refreshed patch is ready on the related ticket #42852

Note: See TracTickets for help on using tickets.