Opened 6 years ago
Last modified 3 years ago
#42780 new enhancement
Code Editor: Linter (HTMLHint) should show error if checkbox doesn't have associated <label>
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 4.9 |
Component: | External Libraries | Keywords: | needs-patch |
Focuses: | accessibility, javascript, rtl | Cc: |
Description
The Custom HTML Linter should show an error if an checkbox field does not have an associated label element. This would be a good improvement for accessibility.
To reproduce:
- Create a custom HTML widget
- Enter the following code:
<input type="checkbox"> Checkbox Label
- No warning/error appears.
Change History (11)
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
6 years ago
#3
@
6 years ago
- Focuses javascript added
- Version changed from trunk to 4.9
Discussed during today's accessibility bug-scrub. Yes it would be great to have the linter warn for accessibility errors, not just the ones related to a checkbox though :) Will defer the decision to the editor and widgets teams, as we're not even sure it's technically feasible.
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
6 years ago
#5
@
6 years ago
- Component changed from Widgets to General
- Milestone changed from Awaiting Review to Future Release
- Summary changed from Custom HTML Widget Linter should show error if checkbox doesn't have associated <label> to Code Editor: Linter (HTMLHint) should show error if checkbox doesn't have associated <label>
#6
@
6 years ago
- Keywords needs-patch added
There's a pull request for HTMLHint already created, sadly not merged for this:
- Rule:
input-requires-label
https://github.com/yaniswang/HTMLHint/pull/159
Unfortunately, it appears the HTMLHint project is unmaintained for now, there's been no response from the maintainer in ~6 months, there are quite a few forks though I'm not sure if it would be possible to use a fork
This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.
5 years ago
#8
@
3 years ago
That pull request was merged in HTMLHint earlier this year.
This ticket was mentioned in Slack in #accessibility by sabernhardt. View the logs.
3 years ago
#10
@
3 years ago
- Component changed from General to External Libraries
The current HTMLHint version included in WordPress is 0.9.14, and the first version with the label-checking feature was 0.13.0
You could write a custom HTMLHint rule to enforce this, but a warning is probably better than an error.