WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#42793 closed defect (bug) (fixed)

Add missing parameter description in get_weekday_initial function DocBlock

Reported by: keesiemeijer's profile keesiemeijer Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: docs Cc:

Description

The get_weekday_initial function DocBlock is missing a description for the $weekday_name parameter.

Attachments (3)

42793.patch​ (449 bytes) - added by keesiemeijer 7 years ago.
Add description
42793.2.diff​ (533 bytes) - added by 1naveengiri 7 years ago.
I think the patch you added is correct but there doc is missing for return param too.
42793.2.2.diff​ (533 bytes) - added by 1naveengiri 7 years ago.
I think the patch you added is correct but there doc is missing for return param too. So in this patch I am adding doc comment for function return param.

Download all attachments as: .zip

Change History (7)

@keesiemeijer
7 years ago

Add description

@1naveengiri
7 years ago

I think the patch you added is correct but there doc is missing for return param too.

@1naveengiri
7 years ago

I think the patch you added is correct but there doc is missing for return param too. So in this patch I am adding doc comment for function return param.

#1 @1naveengiri
7 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 5.0

#3 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42361:

Docs: Add missing description for $weekday_name parameter and @return entry in WP_Locale::get_weekday_initial().

Props keesiemeijer, 1naveengiri.
Fixes #42793.

#4 @johnbillion
6 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.