Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#42801 closed defect (bug) (invalid)

Theme Twenty Seventeen - Why Link underline?

Reported by: reikodd's profile ReikoDD Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

I use a Tag Cloud Widget and installed and tested Simple Tag and Muki Tag Cloud.
This shows the Tag Links in Widget with a "underline". This does not look so good.
I checked with Twenty Sixteen, Twenty Fiveteen and Minimal 20/17.
There have no Tag Links with underline.
Why does this have Twenty Seventeen?

Change History (8)

#1 @ReikoDD
7 years ago

i found the problem in style.css

.widget-area a
{
-webkit-box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1);
box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1);

}

could be replaced

.widget-area a
{
-webkit-box-shadow: none;
box-shadow:none;

}

Last edited 7 years ago by ReikoDD (previous) (diff)

This ticket was mentioned in Slack in #themereview by reikodd. View the logs.


7 years ago

This ticket was mentioned in Slack in #core-themes by reikodd. View the logs.


7 years ago

This ticket was mentioned in Slack in #accessibility by hardeepasrani. View the logs.


7 years ago

This ticket was mentioned in Slack in #accessibility by sami.keijonen. View the logs.


7 years ago

#6 @Cheffheid
7 years ago

  • Keywords close added

In general, having underlines on links is a good idea from an accessibility perspective. It's important for widgets like the Custom HTML widget and for any widget that does similar things - where you could have links in bits of content that would otherwise go unnoticed very easily without that visual indicator. This is why twentseventeen is adding a generic link style with box-shadow underlines.

I think making a change like that and removing them is going to do more harm than good. I feel that this is something you should deal with through a child theme of twentyseventeen or the Additional CSS function in the Customizer. Or use the core tag cloud widget.

Personally, I'd probably drop something like this in the Customizer if I really needed to change the way either of those plugins look:

.widget .st-tags, /* Simple tag cloud */
.muki_tag_cloud a /* Muki tag cloud */ {
	box-shadow: none;
}

#7 @afercia
7 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Version 4.9.1 deleted

Seems to me this is not related to core, but it's about custom widgets added by some plugin, and thus the plugin should take care of the CSS and compatibility with other themes. Going to close this ticket, but please feel free to reopen if I'm missing something.

#8 @SergeyBiryukov
7 years ago

  • Component changed from Themes to Bundled Theme
Note: See TracTickets for help on using tickets.