#42803 closed enhancement (fixed)
Remove @static tags from core DocBlocks
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch commit |
Focuses: | docs, coding-standards | Cc: |
Description
This ticket is for the removal of the @static
tag from core docblocks but not the @staticvar
tag for static variables.
The @static
tag is redundant and similar has been done regarding the @access
tag in #41452.
Also see the comment by @DrewAPicture in ticket:41401#comment:2
The PHPDocumentator mentions that @static
was a helpful tag in PHP-4 but isn't needed for static
keyword usage in PHP-5.
Attachments (2)
Change History (14)
#1
@
7 years ago
- Keywords has-patch dev-feedback added
42803-wp-admin.diff is for the relevant .php
files in wp-admin/*
.
42803-wp-includes-wp-content.diff is for the relevant .php
files in wp-includes/*
and wp-content/*
. It skips these vendor files:
wp-includes/class-phpmailer.php
wp-includes/Text/Diff.php
wp-includes/SimplePie/Misc.php
Hopefully this covers it.
#2
@
7 years ago
- Keywords commit added; dev-feedback removed
- Milestone changed from Awaiting Review to 5.0
Looks good to me
#10
@
7 years ago
- Resolution set to fixed
- Status changed from new to closed
The only instance left is MO::make_entry()
in wp-includes/pomo/mo.php
.
Looks like it was never used as static in core, though could potentially be called as static. MO::get_byteorder()
, on the other hand, is used as static, but is not marked as such.
The whole POMO library does not have access modifiers (it was skipped in #22234, see comment:16:ticket:22234). We could probably reconsider it, but let's do that in a new ticket.
The wp-admin/* classes