type is not required in HTML5

[sasiddiqui]

type is no more required in style and script tags in HTML5. Now HTML Validator start throwing warnings on the script and style tags which contains the types.

Attaching a path which fixes the issues for inline and enqueued files (CSS and JS).

[sasiddiqui]

Fixed the type issue with enqueue and inline script tags

[sasiddiqui]

Fixed the type issue with enqueue and inline style tags

[knutsp]

Hello and welcome to track, sasiddiqui.

Thank your for your suggestion. I agree this would be a nice enhancement. When validating html these warnings comes up. WordPress could do better with making correct html.

Are you able to make a patch with just the changes you propose?

[swissspidy]

Please have a look at ​https://make.wordpress.org/core/handbook/tutorials/working-with-patches/ in order to create patch files that can be more easily scanned. Uploading whole files is unfortunately not really helpful.

Also, just because type is not required anymore with HTML5, it doesn't mean every website or teme is using HTML5. In HTML4 and other doc types, the type attribute is required and will cause validation errors (not just warnings as in your example).

Just removing type might not the best solution. Maybe we need to use add_theme_support for this?

[sasiddiqui]

Fixed the type issue with enqueue and inline style tags updated

[sasiddiqui]

@knutsp Thanks. @swissspidy Sorry about the improper attachments. Would create a patch and add it again.

Apology for the improper files.

[sasiddiqui]

@knutsp @swissspidy Patch has been attached. Let me know if i have done any mistake in it.

@swissspidy As per your concern about the HTML 4 so, i am not sure but i think, mostly themes are working on HTML 5 specially the sites which are working on the latest WordPress Version. It's quite long time when HTML 5 had been introduced.

But, if you guys think that we still need to support the HTML 4 so, we can also add the filter for HTML 4 which doesn't remove the type attr from the script and style tags.

[swissspidy]

Patch has been attached. Let me know if i have done any mistake in it.

Much better, but the patch should only change the lines in question. Right now, it changes lots of the coding style throughout the files and the patch is very long and difficult to scan because of this. It's recommended not to touch irrelevant code sections.

For now and updated code you can use PHP Code Sniffer with the WP Coding Standards (​https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards) to automatically correct coding standards mistakes. The WordPress Git repository contains a phpcs.xml.dist file to automatically configure PHPCS for that.

But, if you guys think that we still need to support the HTML 4 so, we can also add the filter for HTML 4 which doesn't remove the type attr from the script and style tags.

That's what I meant with add_theme_support. There's precedence for that. See ​https://developer.wordpress.org/reference/functions/add_theme_support/#html5

[knutsp]

Something like add_theme_support( 'html5', [ 'script', 'css' ] );?

We already have add_theme_support( 'html5', [ 'comment-list', 'comment-form', 'search-form', 'gallery', 'caption' ] );

Could this be simplified to just add_theme_support( 'html5' ); to catch all?

[swissspidy]

Something like add_theme_support( 'html5', [ 'script', 'css' ] );?

Yeah, something like that.

Could this be simplified to just add_theme_support( 'html5' ); to catch all?

That's how the command worked in the beginning, however it was changed to take an array of features that are supported.

For BC reasons add_theme_support( 'html5' ); is like calling add_theme_support( 'html5', array( 'comment-list', 'comment-form', 'search-form' ) );. I don't think we can change that. Plus, this would warrant its own ticket.

[knutsp]

Replying to swissspidy:

For BC reasons add_theme_support( 'html5' ); is like calling add_theme_support( 'html5', array( 'comment-list', 'comment-form', 'search-form' ) );. I don't think we can change that.

Why not?

Own ticket, of course.

[sasiddiqui]

Please check this patch: https://core.trac.wordpress.org/attachment/ticket/42804/42804-update1.patch

You need to add the add_theme_support in functions.php to remove make the code work.

Something like:

add_theme_support( 'html5', array( 'comment-list', 'comment-form', 'search-form', 'script', 'style' ) );

or

add_theme_support( 'html5', array( 'script', 'style' ) );

[swissspidy]

#42977 was marked as a duplicate.

[ocean90]

#43079 was marked as a duplicate.

[reeslo]

This patch was not added to 4.9.2 ?

[swissspidy]

@reeslo No, this was not added in 4.9.2 as you can see from the history above. The ticket wasn't added to the 4.9.x milestone at any point. However, I think we can add this to 5.0.

[swissspidy]

#43111 was marked as a duplicate.

[sasiddiqui]

@swissspidy Can i own this ticket?

[ocean90]

#44570 was marked as a duplicate.

[gabrieldiggs]

Replying to pento:
Has this been fixed yet? I'm getting the warnings in W3C validator.

EDIT: Added the following function to my theme functions.php and the W3C validation errors are gone. Is this the right way to fix the issue?

//Remove JS and CSS types

add_action( 'template_redirect', function(){
    ob_start( function( $buffer ){
        $buffer = str_replace( array( 'type="text/javascript"', "type='text/javascript'", 'type="text/css"', "type='text/css'" ), '', $buffer );

        return $buffer;
    });
});

[pento]

This patch needs review and a decision.

[sasiddiqui]

Is there any update when it can be deployed in WordPress Core? I can understand that it doesn't have such testing yet but it would be great if any time or WordPress version can be mentioned.

[waterworks2]

Any chance this will be reviewed and approved soon? Would like to clean up those remaining validation errors and get rid of unnecessary code. Thanks.

[sasiddiqui]

@waterworks2 We all are waiting for this.. Hopefully, it will be reviewed and available soon.

[swissspidy]

#46447 was marked as a duplicate.

[dackar]

Any chance this will be reviewed and approved soon? Would like to clean up those remaining validation errors and get rid of unnecessary code. Thanks.

[daymobrew]

Replying to gabrieldiggs:

EDIT: Added the following function to my theme functions.php and the W3C validation errors are gone. Is this the right way to fix the issue?

//Remove JS and CSS types

add_action( 'template_redirect', function(){
    ob_start( function( $buffer ){
        $buffer = str_replace( array( 'type="text/javascript"', "type='text/javascript'", 'type="text/css"', "type='text/css'" ), '', $buffer );

        return $buffer;
    });
});

I did something similar: ​https://www.damiencarbery.com/2018/11/remove-type-from-script-and-style-markup/
I filtered 'script_loader_tag' and 'style_loader_tag' to work on enqueued scripts and styles and used ob_start() and ob_get_contents() on 'wp_head' to process inline scripts and styles.

[SergeyBiryukov]

#47643 was marked as a duplicate.

[SergeyBiryukov]

#48038 was marked as a duplicate.

[gabrieldiggs]

Hello how do I leave this ticket? I have notifications blocked but I keep getting emails with updates. How do I block those?

[SergeyBiryukov]

Replying to gabrieldiggs:

Hello how do I leave this ticket? I have notifications blocked but I keep getting emails with updates. How do I block those?

Sorry for the noise, it's a known problem that's being investigated in ​#meta3594.

[SergeyBiryukov]

In 46164:

Script Loader: Introduce HTML5 support for scripts and styles.

When a theme declares HTML5 support for script and styles via add_theme_support( 'html5', array( 'script', 'style' ) ), the type="text/javascript" and type="text/css" attributes are omitted.

These attributes are unnecessary in HTML5 and cause warnings in the W3C Markup Validation Service.

Props sasiddiqui, swissspidy, knutsp, SergeyBiryukov.
See #42804.

[SergeyBiryukov]

In 46165:

Bundled Themes: Declare HTML5 support for scripts and styles.

Fixes #42804.

[azaozz]

Getting Fatal error: Uncaught Error: Call to undefined function current_theme_supports() in wp-includes\class.wp-scripts.php:145 in load-scripts.php.

load-scripts.php and load-styles.php do not load all of WP. They use sctipt-loader only as a whitelist for scripts and styles.

We can add a stub or a function_exists() for current_theme_supports() but then this (minor) enhancement becomes somewhat redundant? Also it seems it has effect only when outputting individual scripts and styles in wp-admin, i.e. when SCRIPT_DEBUG is true.

Also, would have been nice to also remove the <![CDATA[ stuff :)

[SergeyBiryukov]

In 46170:

Script Loader: Only check current theme's HTML5 support for scripts and styles on front end.

Avoids a fatal error in the admin if SCRIPT_DEBUG is disabled.

Props azaozz.
See #42804.

[SergeyBiryukov]

In 46171:

Script Loader: Move the current_theme_supports() check above the wp_default_(scripts|styles) action, for consistency.

See #42804.

[azaozz]

In 42804.2.diff:

• Add function_exists() when using is_admin() and current_theme_supports(). At some point WP_Dependencies was a separate "package". It's very unlikely but "something" may still be using it that way...
• Remove <![CDATA[ when outputting HTML 5.0 script tags. Not sure if it triggers validation errors, but is super outdated.

@SergeyBiryukov could you have a look in case I'm missing something and commit plz :)

[SergeyBiryukov]

In 46287:

Script Loader: Add function_exists() checks for is_admin() and current_theme_supports(), to accomodate for using WP_Dependencies as a standalone class.

Remove <![CDATA[ when outputting HTML5 script tags.

Props azaozz.
Fixes #42804.

[desrosj]

Mentioned in the Miscellaneous Developer Focused Changes dev note for 5.3: ​https://make.wordpress.org/core/2019/10/15/miscellaneous-developer-focused-changes-in-5-3/

[dufresnesteven]

HTML5 is definitely industry standard. Do we have any plan to move away from it being the exception?

It's nice that we have a way to remove the declarations but in the end it's just more "onboarding" for new developers.

[SergeyBiryukov]

#51447 was marked as a duplicate.

[SergeyBiryukov]

#51447 was marked as a duplicate.

[GermanKiwi]

Hi @SergeyBiryukov et al,

I have a plugin which adds a <script> tag to the footer of every page, and the tag includes the type="module" attribute.

I've discovered that if I use the "add_theme_support" function to add html5 support for scripts, it not only results in the type="text/javascript" attribute being removed from all <script> tags, but the type="module" attribute is also removed too, which is a problem - this attribute is still needed and still valid under HTML5.

The description of this patch at the top of this page is incorrect to state that "type is no more required" under HTML5 - in fact, only the JavaScript MIME type is no longer required. Other values for type, such as "module", are still valid:
​https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script

Question: is it possible the patch provided here is also stripping out the type="module" attribute?

If so, could that please be reversed or fixed, so that this attribute is not removed?

[SergeyBiryukov]

Replying to GermanKiwi:

Question: is it possible the patch provided here is also stripping out the type="module" attribute?

If so, could that please be reversed or fixed, so that this attribute is not removed?

Hi there, welcome to WordPress Trac!

As far as I can tell, the changes in [46164] should only specifically affect the type="text/javascript" attribute, but I have not tested them with other values.

Please note that this ticket was closed on a completed milestone and may not receive enough attention for further updates. If the issue is still relevant, could you create a new ticket for investigation? Thanks!