WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#42808 closed defect (bug) (fixed)

Remove old style PHPCS ignore comments

Reported by: netweb's profile netweb Owned by: pento's profile pento
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

Currently, there are 4 files in /tests that use the PHPCS 2.x @codingStandardsIgnore* ignore comment syntax

These should be updated to the new ​PHPCS 3.2 syntax or removed if no longer required.

Attachments (1)

42808.diff​ (3.0 KB) - added by netweb 7 years ago.

Download all attachments as: .zip

Change History (7)

@netweb
7 years ago

#1 @netweb
7 years ago

  • Keywords has-patch commit added

In 42808.diff​:

Coding Standards:

  • Remove legacy PHPCS 2.x @codingStandardsIgnore* ignore comments from tests/phpunit/tests/customize
  • Update code to meet current WPCS standards (Generic.Formatting.MultipleStatementAlignment.NotSameWarning)

#2 @jrf
7 years ago

👍

#3 @netweb
7 years ago

  • Focuses coding-standards added
  • Keywords coding-standards removed

#4 @GaryJ
7 years ago

Looks good.

#5 @jorbin
6 years ago

  • Milestone changed from 5.0 to 5.1

#6 @pento
6 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 44559:

Coding Standards: Remove PHPCS 2.x @codingStandardsIgnore* ignore syntax.

Props netweb.
Fixes #42808.

Note: See TracTickets for help on using tickets.