WordPress.org

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #42811


Ignore:
Timestamp:
12/08/2017 03:45:58 AM (3 years ago)
Author:
dd32
Comment:

Just noticed I incorrectly referenced mysqli_* functions instead of mysql_* functions :)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42811

    • Property Keywords commit added
    • Property Milestone changed from Awaiting Review to 5.0
  • Ticket #42811 – Description

    initial v3  
    11I just noticed that the PHP 5.2 job is running with MySQLi (which I didn't even realise was possible).
    22
    3 That ultimately means we have no automated testing which is testing the `mysqli_*` functions in `$wpdb` which is used for PHP 5.2~5.4 by default.
     3That ultimately means we have no automated testing which is testing the `mysql_*` functions in `$wpdb` which is used for PHP 5.2~5.4 by default.
    44
    55The attached patch uses `WP_USE_EXT_MYSQL` to force it to use the MySQL extension for the PHP 5.2 job, I've tested this on [https://travis-ci.org/dd32/wordpress-develop/jobs/312272686 my own travis account] and it passes as expected, with the only change being an additional skipped test (which requires mysqli).