WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#42832 closed enhancement (fixed)

Improve JS Documentation: /js/media/views/attachments.js

Reported by: maartenleenders's profile maartenleenders Owned by: adamsilverstein's profile adamsilverstein
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Media Keywords: has-patch
Focuses: javascript, docs Cc:

Description

In our ongoing effort to improve JavaScript documentation, this patch adds descriptions and JSDoc formatting to the following file:

  • src/wp-includes/js/media/views/attachments.js

Please give props to:
-​herregroen
-​jipmoors
-​ireneyoast

Attachments (1)

attachments.js.diff​ (11.1 KB) - added by maartenleenders 7 years ago.

Download all attachments as: .zip

Change History (11)

@maartenleenders
7 years ago

#1 @netweb
7 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to adamsilverstein
  • Status changed from new to assigned

#2 @netweb
7 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core-js by atimmer. ​View the logs.
7 years ago

#4 @atimmer
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42415:

Docs: Improve JSDoc for media/views/attachments.js.

Props maartenleenders, herregroen, jipmoors, ireneyoast.
Fixes #42832.

#5 @netweb
7 years ago

#42955 was marked as a duplicate.

#6 @johnbillion
6 years ago

  • Milestone changed from 5.0 to 5.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#8 @pento
6 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#9 @audrasjb
6 years ago

  • Milestone changed from 5.0.3 to 5.1

Hi,

Per today's bug scrub, we are going to address Docs enhancements in 5.1, coming next month.

#10 @atimmer
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

As this has landed in trunk and 5.1 will release everything in trunk, I'll close this.

Note: See TracTickets for help on using tickets.