WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 19 months ago

Last modified 19 months ago

#42862 closed task (blessed) (fixed)

Emoji: Update Twemoji to v2.4.0

Reported by: pento Owned by: SergeyBiryukov
Milestone: 4.9.3 Priority: normal
Severity: normal Version:
Component: Emoji Keywords: needs-refresh needs-patch
Focuses: Cc:

Description

Note: we're already on 2.5.0, but they decided to break their versioning, so 2.4.0 is actually the latest release.

Attachments (1)

42862-support-test.diff (933 bytes) - added by peterwilsoncc 19 months ago.

Download all attachments as: .zip

Change History (19)

#1 @dd32
19 months ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

#2 @SergeyBiryukov
19 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42566:

Emoji: Update Twemoji to 2.4.0.

WordPress was already on 2.5.0, but Twemoji decided to break their versioning, so 2.4.0 is actually the latest release.

Fixes #42862.

#3 @SergeyBiryukov
19 months ago

In 42567:

Emoji: Update Twemoji to 2.4.0.

WordPress was already on 2.5.0, but Twemoji decided to break their versioning, so 2.4.0 is actually the latest release.

Merges [42566] to the 4.9 branch.
Fixes #42862.

#4 @peterwilsoncc
19 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @peterwilsoncc
19 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42579:

Emoji: Update emoji regex for Twemoji to 2.4.0.

Build src/wp-includes/formatting.php following [42566].

Fixes #42862.

#6 @peterwilsoncc
19 months ago

  • Keywords fixed-major added; needs-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting build to the 4.9 branch.

#7 @SergeyBiryukov
19 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42580:

Emoji: Update emoji regex for Twemoji to 2.4.0.

Build src/wp-includes/formatting.php following [42566].

Props peterwilsoncc.
Merges [42579] to the 4.9 branch.
Fixes #42862.

#8 @dd32
19 months ago

Looks like we need to update the CDN with the new emoji assets too.

@pento feel like taking care of that?

#9 @pento
19 months ago

  • Keywords needs-refresh needs-patch added; fixed-major removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Done. _print_emoji_detection_script() and wp_staticize_emoji() need to be updated to point to the correct base URL.

https://s.w.org/images/core/emoji/2.4/72x72/1f574-fe0f-200d-2640-fe0f.png

#10 @SergeyBiryukov
19 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42590:

Emoji: Update emoji base URL in _print_emoji_detection_script() and wp_staticize_emoji().

Props pento.
Fixes #42862.

#11 @SergeyBiryukov
19 months ago

In 42591:

Emoji: Update emoji base URL in _print_emoji_detection_script() and wp_staticize_emoji().

Merges [42590] to the 4.9 branch.
Props pento.
Fixes #42862.

#12 @SergeyBiryukov
19 months ago

In 42592:

Tests: Update emoji base URL in Tests_Formatting_Emoji after [42590].

See #42862.

#13 @SergeyBiryukov
19 months ago

In 42593:

Tests: Update emoji base URL in Tests_Formatting_Emoji after [42590].

Merges [42592] to the 4.9 branch.
See #42862.

#14 @peterwilsoncc
19 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The support tests will require an update to replace the fairy (male) with the levitating person in business suit (woman).

In the previous update, the rainbow flag was replaced with the UN's but WordPress gained a fairy. These differences may become less obvious as time moves on but it's these differences that will make you rise above the crowd.

#15 @peterwilsoncc
19 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42598:

Emoji: Update Emoji browser support tests for Twemoji v2.4.0

Replaces the fairy (male) browser support test with a woman in business suit levitating. While the things that make people different sometimes become less obvious this isn't always a problem, because the things that make you strange are the things that make you powerful.

Fixes #42862 for trunk.

#16 @SergeyBiryukov
19 months ago

In 42601:

Emoji: Update Emoji browser support tests for Twemoji v2.4.0

Replaces the fairy (male) browser support test with a woman in business suit levitating. While the things that make people different sometimes become less obvious this isn't always a problem, because the things that make you strange are the things that make you powerful.

Props peterwilsoncc.
Merges [42598] to the 4.9 branch.
Fixes #42862.

#17 @peterwilsoncc
19 months ago

In 42602:

Emoji: Update Emoji browser support tests for Twemoji v2.4.0

Really, following [42598].

Fixes #42862 for trunk, really.

#18 @SergeyBiryukov
19 months ago

In 42603:

Emoji: Update Emoji browser support tests for Twemoji v2.4.0

Really, following [42598].

Props peterwilsoncc.
Merges [42602] to the 4.9 branch.
Fixes #42862.

Note: See TracTickets for help on using tickets.