Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42873


Ignore:
Timestamp:
12/11/2017 07:07:58 PM (8 years ago)
Author:
westonruter
Comment:

See patch https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42873

    • Property Keywords has-patch added
  • Ticket #42873 – Description

    initial v1  
    33Next steps:
    44- Revert [41997]
    5 - Use [attachment:42184.2.diff]
     5- Use [https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff 42184.2.diff]
    66- Fix the two known bugs: incorrect labels after cancelling the modal, and fix broken buttons after cancelling the modal
    77
    8 Note that with [attachment:42184.2.diff], SFTP appears to work as expected. The only issues are with canceling the modal, which happens much more in testing than in practice. [41997] seems like an overreaction to the minor bugs that we need to track down with that, which may seem worse than they are because they are more apparent in a testing workflow than in real usage. Either way, the fixes for that should not be particularly difficult. I'm not planning on working on this issue further, so someone else can take it on.
     8Note that with [https://core.trac.wordpress.org/attachment/ticket/42184/42184.2.diff 42184.2.diff], SFTP appears to work as expected. The only issues are with canceling the modal, which happens much more in testing than in practice. [41997] seems like an overreaction to the minor bugs that we need to track down with that, which may seem worse than they are because they are more apparent in a testing workflow than in real usage. Either way, the fixes for that should not be particularly difficult. I'm not planning on working on this issue further, so someone else can take it on.