Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #42888, comment 11


Ignore:
Timestamp:
01/19/2018 07:16:10 AM (7 years ago)
Author:
Iceable
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42888, comment 11

    v2 v3  
    99* Added some padding to the right password field. This prevents the password value and the icon from overlapping, in case of very long passwords.
    1010
     11[EDIT] My bad, I forgot to have the `aria-label` attribute for the button to toggle between `Show password` and `Hide password`. This is included in 42888-3.diff.
     12
    1113About other places where passwords are entered, as @audrasjb mentioned, this was a first iteration to test and validate the approach.
    1214If I'm not mistaken, the only other places where passwords are entered are the ones below and they already have a show/hide button: