Changes between Version 3 and Version 4 of Ticket #42888, comment 11
- Timestamp:
- 01/19/2018 08:12:54 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #42888, comment 11
v3 v4 1 42888-2.diff is based on 42888.diff, with the following changes:1 ~~42888-2.diff~~ [attachment:42888-3.diff] is based on [attachment:42888.diff], with the following changes: 2 2 3 3 * Swapped `dashicons-visibility` and `dashicons-hidden` icons: the first patch was using icons to describe the current state of the field ("dashicon-hidden" when the password is hidden). Since the icon is a clickable button, I think it makes more sense to describe the action (i.e. click the "dashicons-visibility" icon to make the password visible). This is also consistent with the buttons that already exist in other places. … … 9 9 * Added some padding to the right password field. This prevents the password value and the icon from overlapping, in case of very long passwords. 10 10 11 [EDIT] My bad, I forgot to have the `aria-label` attribute for the button to toggle between `Show password` and `Hide password`. This is included in 42888-3.diff.11 * [EDIT] My bad, I forgot to have the `aria-label` attribute for the button to toggle between `Show password` and `Hide password`. This is included in [attachment:42888-3.diff]. 12 12 13 13 About other places where passwords are entered, as @audrasjb mentioned, this was a first iteration to test and validate the approach.