WordPress.org

Make WordPress Core

#42909 closed task (blessed) (fixed)

Ignore Composer `/vendor` folder

Reported by: netweb Owned by: johnbillion
Milestone: 5.0 Priority: normal
Severity: normal Version: 5.1
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

Following #41057 a Composer /vendor folder might now exist, we should ignore it.

Attachments (2)

42909.diff (595 bytes) - added by netweb 22 months ago.
42909-50branch.diff (647 bytes) - added by netweb 12 months ago.

Download all attachments as: .zip

Change History (12)

@netweb
22 months ago

#1 @netweb
22 months ago

  • Keywords has-patch commit added
  • Version set to trunk

#2 @johnbillion
22 months ago

  • Owner set to johnbillion
  • Status changed from new to reviewing
  • Type changed from defect (bug) to task (blessed)

#3 follow-up: @johnbillion
22 months ago

I'm going to add the vendor directory to the SVN ignored directories too.

#4 @johnbillion
22 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 42405:

Build/Test Tools: Instruct Git and Subversion to ignore Composer's vendor directory.

Props netweb
Fixes #42909

#5 in reply to: ↑ 3 @netweb
22 months ago

Replying to johnbillion:

I'm going to add the vendor directory to the SVN ignored directories too.

Thanks John, the svn:ignore was in 42909.diff, Trac just doesn't render these patches terribly well ;)

#6 @jorbin
12 months ago

  • Milestone changed from 5.0 to 5.1

#7 @netweb
12 months ago

  • Milestone changed from 5.1 to 5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

As part of adding PHPCS to the 5.0 branch reopening and moving back to the 5.0 milestone

#8 @netweb
12 months ago

Patch 42909-50branch.diff for the 5.0 branch is ready for commit

Note: The patch includes the changes for svn:ignore, highly unlikely it will applied when applying the patch though.

To edit svn:ignore run svn propedit svn:ignore . from the command line and add vendor after jsdoc

Index: .
===================================================================
--- .   (revision 43735)
+++ .   (working copy)

Property changes on: .
___________________________________________________________________
Modified: svn:ignore
## -8,6 +8,7 ##
 node_modules
 npm-debug.log
 build
 wp-cli.local.yml
 .git
 jsdoc
+vendor

#9 @netweb
12 months ago

Patch 42909-50branch.diff is based on [42405] for backporting to the 5.0 branch

#10 @SergeyBiryukov
12 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43748:

Build/Test Tools: Instruct Git and Subversion to ignore Composer's vendor directory.

Props netweb.
Merges [42405] to the 5.0 branch.
Fixes #42909.

Note: See TracTickets for help on using tickets.