WordPress.org

Make WordPress Core

Opened 2 years ago

#42916 new defect (bug)

Terms for taxonomy with show_in_quick_edit = false still load in inline data

Reported by: jazbek Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.9.1
Component: Administration Keywords:
Focuses: performance Cc:
PR Number:

Description

The show_in_quick_edit property was introduced for taxonomies in 4.2 with changeset:

https://core.trac.wordpress.org/changeset/31307

This changeset removed the taxonomy from the inline edit form, but the terms for the taxonomy are still being populated in the data for each row via the get_inline_data() function, which only respects $taxonomy->show_ui.

One reason people may want to remove a taxonomy from quick edit is for performance reasons, when the number of terms fore each post are huge. However, the terms are still being loaded, and the page can take a huge performance hit.

For example, I have a custom post type where each one is assigned thousands of zip codes via a custom taxonomy. I set show_in_quick_edit to false on the taxonomy, but the post listing was still loading very slow. I looked at the source code, and saw thousands of zip codes being rendered in a hidden div on each row.

Attachments (1)

patch.diff (944 bytes) - added by jazbek 2 years ago.

Download all attachments as: .zip

Change History (1)

@jazbek
2 years ago

Note: See TracTickets for help on using tickets.