![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Closed 4 years ago
#42916 closed defect (bug) (fixed)
Terms for taxonomy with show_in_quick_edit = false still load in inline data
| Reported by: | jazbek | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.0 |
| Component: | Quick/Bulk Edit | Version: | 4.9.1 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: | Focuses: | performance |
Description (last modified by )
The show_in_quick_edit property was introduced for taxonomies in 4.2 with changeset: [31307].
This changeset removed the taxonomy from the inline edit form, but the terms for the taxonomy are still being populated in the data for each row via the get_inline_data() function, which only respects $taxonomy->show_ui.
One reason people may want to remove a taxonomy from quick edit is for performance reasons, when the number of terms fore each post are huge. However, the terms are still being loaded, and the page can take a huge performance hit.
For example, I have a custom post type where each one is assigned thousands of zip codes via a custom taxonomy. I set show_in_quick_edit to false on the taxonomy, but the post listing was still loading very slow. I looked at the source code, and saw thousands of zip codes being rendered in a hidden div on each row.
Attachments (1)
Change History (8)
#3
@
4 years ago
- Keywords has-patch needs-testing added
- Milestone Awaiting Review → 6.0
The patch still applies cleanly to src, but I have not (yet) confirmed whether it fixes the issue.
Related/duplicate: #49701
(A more recent ticket proposes the same two changes for /wp-admin/includes/template.php)