WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 3 weeks ago

#42919 closed defect (bug) (fixed)

Unable to upload files with the AAC extension

Reported by: desrosj Owned by: desrosj
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 2.5
Component: Media Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Uploading a file with the .aac extension returns the Sorry, this file type is not permitted for security reasons. error. The AAC format is basically an MP3, and uploading should be allowed.

Attachments (2)

42919.diff (574 bytes) - added by desrosj 5 months ago.
Add the AAC mime type.
small-audio.aac (33.0 KB) - added by SergeyBiryukov 3 weeks ago.

Download all attachments as: .zip

Change History (24)

@desrosj
5 months ago

Add the AAC mime type.

#1 @desrosj
5 months ago

  • Milestone changed from Awaiting Review to 5.0

#2 @desrosj
5 months ago

  • Version set to 2.5

#3 @desrosj
5 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-media by desrosj. View the logs.


5 months ago

This ticket was mentioned in Slack in #core-media by blobfolio. View the logs.


5 months ago

#6 @chetan200891
4 months ago

Hi @desrosj

Tested 42919.diff

Works fine for me!

This ticket was mentioned in Slack in #core-media by mike. View the logs.


4 months ago

#8 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42697:

Media: Add aac to the list of allowed file types.

Props desrosj.
Fixes #42919.

This ticket was mentioned in Slack in #core-media by desrosj. View the logs.


2 months ago

This ticket was mentioned in Slack in #core-media by desrosj. View the logs.


2 months ago

#11 follow-up: @desrosj
2 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this for two reasons.

  1. The original intention of the ticket was to allow users to upload a file with the .aac extension. Uploading a file with the aac mime type was allowed, but only if it was used in an MP4 container. This is a bug fix, and I think that the fix in 42919.diff should be backported to the 4.9 branch.
  1. r42697 also adds support to the media player for .aac files. This does not work in FireFox, though (https://caniuse.com/#search=aac). The player will draw correctly, but the media will not play. Because of this, I think that part of the commit should be reverted.

We talked this over in this week's Media chat, and there was agreement that if a format is explicitly supported for use in the editor and within embeds, there should not be any bad user experiences.

@SergeyBiryukov wanted to follow up to see if there was something we missed or if there was a reason you added that.

#12 @SergeyBiryukov
2 months ago

  • Milestone changed from 5.0 to 4.9.6

This ticket was mentioned in Slack in #core by desrosj. View the logs.


6 weeks ago

#14 @desrosj
5 weeks ago

@SergeyBiryukov do you need anything else from me for this one?

#15 @desrosj
5 weeks ago

  • Keywords commit added

This ticket was mentioned in Slack in #core by desrosj. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.


4 weeks ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


4 weeks ago

#19 @desrosj
4 weeks ago

  • Keywords fixed-major added; needs-testing removed

#20 in reply to: ↑ 11 @SergeyBiryukov
3 weeks ago

Replying to desrosj:

r42697 also adds support to the media player for .aac files. This does not work in FireFox, though (https://caniuse.com/#search=aac). The player will draw correctly, but the media will not play. Because of this, I think that part of the commit should be reverted.

I've tested several .aac files in Firefox on Windows 10 and they worked as expected, though I guess they might not work in other configurations. For reference, small-audio.aac is one of the files I used. It's small-audio.flac from the test suite, converted to AAC.

That said, I have no problem reverting that part of the commit and reconsidering it at some point later when Firefox fully supports AAC.

#21 @SergeyBiryukov
3 weeks ago

In 43135:

Media: Remove media player support for .aac files due to only partial support in Firefox.

This still allows .aac files to be uploaded, but does not explicitly declare support for use in the editor and within embeds to prevent bad UX.

Props desrosj.
See #42919.

#22 @SergeyBiryukov
3 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43136:

Media: Add aac to the list of allowed file types.

Props desrosj.
Merges [42697] and [43135] to the 4.9 branch.
Fixes #42919.

Note: See TracTickets for help on using tickets.