Opened 6 years ago
Closed 6 years ago
#42919 closed defect (bug) (fixed)
Unable to upload files with the AAC extension
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9.6 | Priority: | normal |
Severity: | normal | Version: | 2.5 |
Component: | Media | Keywords: | has-patch commit fixed-major |
Focuses: | Cc: |
Description
Uploading a file with the .aac
extension returns the Sorry, this file type is not permitted for security reasons.
error. The AAC format is basically an MP3, and uploading should be allowed.
Attachments (2)
Change History (24)
This ticket was mentioned in Slack in #core-media by desrosj. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-media by blobfolio. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-media by mike. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-media by desrosj. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-media by desrosj. View the logs.
6 years ago
#11
follow-up:
↓ 20
@
6 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening this for two reasons.
- The original intention of the ticket was to allow users to upload a file with the
.aac
extension. Uploading a file with theaac
mime type was allowed, but only if it was used in an MP4 container. This is a bug fix, and I think that the fix in 42919.diff should be backported to the4.9
branch.
- r42697 also adds support to the media player for
.aac
files. This does not work in FireFox, though (https://caniuse.com/#search=aac). The player will draw correctly, but the media will not play. Because of this, I think that part of the commit should be reverted.
We talked this over in this week's Media chat, and there was agreement that if a format is explicitly supported for use in the editor and within embeds, there should not be any bad user experiences.
@SergeyBiryukov wanted to follow up to see if there was something we missed or if there was a reason you added that.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
#20
in reply to:
↑ 11
@
6 years ago
Replying to desrosj:
r42697 also adds support to the media player for
.aac
files. This does not work in FireFox, though (https://caniuse.com/#search=aac). The player will draw correctly, but the media will not play. Because of this, I think that part of the commit should be reverted.
I've tested several .aac
files in Firefox on Windows 10 and they worked as expected, though I guess they might not work in other configurations. For reference, small-audio.aac is one of the files I used. It's small-audio.flac
from the test suite, converted to AAC.
That said, I have no problem reverting that part of the commit and reconsidering it at some point later when Firefox fully supports AAC.
Add the AAC mime type.