Unable to upload files with the AAC extension

[desrosj]

Uploading a file with the .aac extension returns the Sorry, this file type is not permitted for security reasons. error. The AAC format is basically an MP3, and uploading should be allowed.

[desrosj]

Add the AAC mime type.

[chetan200891]

Hi @desrosj

Tested 42919.diff

Works fine for me!

[SergeyBiryukov]

In 42697:

Media: Add aac to the list of allowed file types.

Props desrosj.
Fixes #42919.

[desrosj]

Reopening this for two reasons.

1. The original intention of the ticket was to allow users to upload a file with the .aac extension. Uploading a file with the aac mime type was allowed, but only if it was used in an MP4 container. This is a bug fix, and I think that the fix in 42919.diff​ should be backported to the 4.9 branch.

2. r42697 also adds support to the media player for .aac files. This does not work in FireFox, though (​https://caniuse.com/#search=aac). The player will draw correctly, but the media will not play. Because of this, I think that part of the commit should be reverted.

We talked this over in this week's Media chat, and there was agreement that if a format is explicitly supported for use in the editor and within embeds, there should not be any bad user experiences.

@SergeyBiryukov wanted to follow up to see if there was something we missed or if there was a reason you added that.

[desrosj]

@SergeyBiryukov do you need anything else from me for this one?

[SergeyBiryukov]

Replying to desrosj:

r42697 also adds support to the media player for .aac files. This does not work in FireFox, though (​https://caniuse.com/#search=aac). The player will draw correctly, but the media will not play. Because of this, I think that part of the commit should be reverted.

I've tested several .aac files in Firefox on Windows 10 and they worked as expected, though I guess they might not work in other configurations. For reference, small-audio.aac​ is one of the files I used. It's small-audio.flac from the test suite, converted to AAC.

That said, I have no problem reverting that part of the commit and reconsidering it at some point later when Firefox fully supports AAC.

[SergeyBiryukov]

In 43135:

Media: Remove media player support for .aac files due to only partial support in Firefox.

This still allows .aac files to be uploaded, but does not explicitly declare support for use in the editor and within embeds to prevent bad UX.

Props desrosj.
See #42919.

[SergeyBiryukov]

In 43136:

Media: Add aac to the list of allowed file types.

Props desrosj.
Merges [42697] and [43135] to the 4.9 branch.
Fixes #42919.