WordPress.org

Make WordPress Core

Opened 18 months ago

Last modified 9 days ago

#42938 new feature request

Avatar Blank Space

Reported by: Marius84 Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version: 4.9.1
Component: Administration Keywords: has-screenshots has-patch
Focuses: ui, administration Cc:

Description

Wordpress --> Settings --> Discussion --> Avatar Display --> Uncheck Show Avatar option.

If I can choose not to show the avatar the blank space shouldn’t be there.

screenshot 1: https://www.dropbox.com/s/3mj8fmsd3t9vycs/Screenshot%202017-12-19%2005.53.21.png?dl=0

screenshot 2: https://www.dropbox.com/s/1ip4fmozaub5nyw/Screenshot%202017-12-19%2013.49.19.png?dl=0

screenshot 3: https://www.dropbox.com/s/9013zsym8v8gltc/Screenshot%202017-12-19%2013.58.09.png?dl=0

Also all themes will show on live website this "Blank Space Location On comment Area" if i deactivated the Avatar Display. If I can choose not to show the avatar the blank space location shouldn’t be there.

https://wordpress.org/support/topic/wordpress-4-9-1-bug-2/

Attachments (9)

Screenshot 2017-12-19 05.53.21.png (60.9 KB) - added by Marius84 18 months ago.
Screenshot 2017-12-19 13.49.19.png (54.4 KB) - added by Marius84 18 months ago.
Screenshot 2017-12-19 13.58.09.png (46.1 KB) - added by Marius84 18 months ago.
42938.patch (995 bytes) - added by Shital Patel 18 months ago.
Created patch for Avatar in Recent Comments section on Dashboard
42938.1.patch (1.0 KB) - added by Shital Patel 18 months ago.
42938-before-patch.PNG (17.7 KB) - added by ianbelanger 3 months ago.
Before applying patch
42938-after-patch.PNG (18.3 KB) - added by ianbelanger 3 months ago.
After applying patch
42938-3.diff (1.5 KB) - added by sgastard 3 months ago.
42938.4.diff (3.1 KB) - added by ianbelanger 9 days ago.

Download all attachments as: .zip

Change History (24)

@Shital Patel
18 months ago

Created patch for Avatar in Recent Comments section on Dashboard

#1 @williampatton
18 months ago

  • Type changed from defect (bug) to enhancement

#2 @Shital Patel
18 months ago

  • Focuses ui administration coding-standards added
  • Keywords has-patch added

#3 @GaryJ
18 months ago

  • Focuses coding-standards removed

This isn't related to adhering to coding standards, so removing the focus.

Identification of the bug looks good, assuming that the intent of the Show Avatar was meant for the back end, as well as the front end.

#4 @SergeyBiryukov
18 months ago

  • Milestone changed from Awaiting Review to 5.0

#5 @johnbillion
8 months ago

  • Milestone changed from 5.0 to 5.1

#6 follow-up: @Marius84
6 months ago

Hello, WP 5.0 installed problem persist, any update on this? Thank you all.

#7 in reply to: ↑ 6 @knutsp
6 months ago

Replying to Marius84:

Hello, WP 5.0 installed problem persist, any update on this? Thank you all.

As you can see by the milestone field in the ticket header, and also previous comment, this is intended to be fixed in WordPress 5.1.

#8 @pento
5 months ago

  • Keywords needs-testing added
  • Milestone changed from 5.1 to 5.2

42938.1.patch needs testing and a decision.

#9 @Marius84
5 months ago

My wordpress 5.0.3 admin dashboard look horrible just because I don't use Avatar. Hope we can have some news about this subject in wordpress 5.2
Thanks guys! I tested the patch and work like a charm!

Last edited 5 months ago by Marius84 (previous) (diff)

#10 @Shital Patel
5 months ago

  • Type changed from enhancement to feature request

@ianbelanger
3 months ago

Before applying patch

@ianbelanger
3 months ago

After applying patch

#11 follow-up: @ianbelanger
3 months ago

  • Keywords needs-patch has-screenshots added; has-patch removed
  • Milestone changed from 5.2 to 5.3

Just tested the patch and it does make the requested changes, however there is an unintended consequence when your comment contains a long non-breaking word/string. See screenshots above.

Since this is not ready for 5.2 Beta 1, which is tomorrow and is a Feature Request. I am punting to 5.3

@sgastard
3 months ago

#12 in reply to: ↑ 11 @sgastard
3 months ago

  • Keywords has-patch added; needs-patch removed

Replying to ianbelanger:

Just tested the patch and it does make the requested changes, however there is an unintended consequence when your comment contains a long non-breaking word/string. See screenshots above.

Since this is not ready for 5.2 Beta 1, which is tomorrow and is a Feature Request. I am punting to 5.3

Add new class dashboard-comment-wrap-no-avatar to keep the word-wrap property

#13 @lgrev01
10 days ago

Just tested the patch and it does make de requested changes, but when I go back and want to show the avatars again. It doesn't show the avatar anymore.

#14 @lgrev01
10 days ago

  • Keywords needs-testing removed

@ianbelanger
9 days ago

#15 @ianbelanger
9 days ago

Just tested the patch and it does make de requested changes, but when I go back and want to show the avatars again. It doesn't show the avatar anymore.

42938.4.diff should fix the issue and also includes some coding standards updates.

Note: See TracTickets for help on using tickets.