Avatar Blank Space

[Marius84]

Wordpress --> Settings --> Discussion --> Avatar Display --> Uncheck Show Avatar option.

If I can choose not to show the avatar the blank space shouldn’t be there.

screenshot 1: ​https://www.dropbox.com/s/3mj8fmsd3t9vycs/Screenshot%202017-12-19%2005.53.21.png?dl=0

screenshot 2: ​https://www.dropbox.com/s/1ip4fmozaub5nyw/Screenshot%202017-12-19%2013.49.19.png?dl=0

screenshot 3: ​https://www.dropbox.com/s/9013zsym8v8gltc/Screenshot%202017-12-19%2013.58.09.png?dl=0

Also all themes will show on live website this "Blank Space Location On comment Area" if i deactivated the Avatar Display. If I can choose not to show the avatar the blank space location shouldn’t be there.

​https://wordpress.org/support/topic/wordpress-4-9-1-bug-2/

[Shital Patel]

Created patch for Avatar in Recent Comments section on Dashboard

[GaryJ]

This isn't related to adhering to coding standards, so removing the focus.

Identification of the bug looks good, assuming that the intent of the Show Avatar was meant for the back end, as well as the front end.

[Marius84]

Hello, WP 5.0 installed problem persist, any update on this? Thank you all.

[knutsp]

Replying to Marius84:

Hello, WP 5.0 installed problem persist, any update on this? Thank you all.

As you can see by the milestone field in the ticket header, and also previous comment, this is intended to be fixed in WordPress 5.1.

[pento]

42938.1.patch​ needs testing and a decision.

[Marius84]

My wordpress 5.0.3 admin dashboard look horrible just because I don't use Avatar. Hope we can have some news about this subject in wordpress 5.2
Thanks guys! I tested the patch and work like a charm!

[ianbelanger]

Before applying patch

[ianbelanger]

After applying patch

[ianbelanger]

Just tested the patch and it does make the requested changes, however there is an unintended consequence when your comment contains a long non-breaking word/string. See screenshots above.

Since this is not ready for 5.2 Beta 1, which is tomorrow and is a Feature Request. I am punting to 5.3

[sgastard]

Replying to ianbelanger:

Just tested the patch and it does make the requested changes, however there is an unintended consequence when your comment contains a long non-breaking word/string. See screenshots above.

Since this is not ready for 5.2 Beta 1, which is tomorrow and is a Feature Request. I am punting to 5.3

Add new class dashboard-comment-wrap-no-avatar to keep the word-wrap property

[lgrev01]

Just tested the patch and it does make de requested changes, but when I go back and want to show the avatars again. It doesn't show the avatar anymore.

[ianbelanger]

Just tested the patch and it does make de requested changes, but when I go back and want to show the avatars again. It doesn't show the avatar anymore.

42938.4.diff​ should fix the issue and also includes some coding standards updates.

[donmhico]

I can confirm that 42938.4.diff works. But I think we should also account the "No avatar" option on bundled themes for the front end as well. But that can be as another ticket.

[desrosj]

This one is not applying cleanly for me. Can someone please give it a refresh?

[garrett-eclipse]

Refresh

[garrett-eclipse]

@desrosj can you give 42938.5.diff a shot.

It's a refresh and addresses minor CS issues. One lucky happenstance was the CS fix on the main PHP block that appeared changed in 42938.4.diff was it's indention which is why it's no longer appearing in the latest diff as that doesn't change from what's in trunk.

@ianbelanger or @donmhico can you confirm as you have more background on this ticket.

As well @donmhico did you create another ticket for this thought?
"But I think we should also account the "No avatar" option on bundled themes for the front end as well. But that can be as another ticket."
*If so please post the reference for relation.

Thanks

[garrett-eclipse]

One tiny tweak, moved the space off the $show_avatars_class setup and just placed after <?php echo $show_avatars_class; ?> as it will always be needed

[desrosj]

With 5.3 beta 1 in a few hours, this unfortunately needs to be punted.

[Marius84]

I hoped in vain that it would be solved in WordPress 5.3 and now the milestone has been moved to 5.4 a real disappointment

[audrasjb]

The patch doesn't applies cleanly anymore on my side. Going to refresh it.

[audrasjb]

Testing last patch: works fine.

[audrasjb]

Refreshed patch

[audrasjb]

Patch refreshed. Works fine on my side, I think it's ready to go.

[garrett-eclipse]

Before

[garrett-eclipse]

After

[garrett-eclipse]

Thanks for the refresh @audrasjb testing this is working nicely. I think we're safe marking this for commit.

One note about your latest patch, I'm not sure why it does this really but am getting;

patch unexpectedly ends in middle of line
Hunk #2 succeeded at 808 with fuzz 1.

Seems this is just a CRLF windows line ending from a git diff that it's complaining about but the patch applies cleanly without issue so I don't see it as a concern, just flagging in case.

[audrasjb]

New patch to address the LF/CRLF issue reported by Garrett

[audrasjb]

Hi there,

I verified the previous patch and it still applies cleanly.
It’s still on track for 5.4, we just need a commit action here.

[ianbelanger]

Patch looks good to me, reviewing for commit

[ianbelanger]

Since this is not a theme ticket, I cannot commit it, but the patch looks good. @desrosj can you get this in?

[SergeyBiryukov]

In 47255:

Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen.

Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov.
Fixes #42938.

[SergeyBiryukov]

In 47256:

Administration: Move .has-row-actions class in Recent Comments dashboard widget next to .dashboard-comment-wrap, for consistency.

Follow-up to [47255].

See #42938.