Provide a post_date_column_time hook for media files

[ivanlutrov]

Class class-wp-posts-list-table.php has column_date() function which uses post_date_column_time hook to filter the date.

Class class-wp-media-list-table.php has column_date() function which has no hook to filter the date.

[lopo]

Add a media_date_column_time filter

[ivanlutrov]

Is there a reason we can't just use post_date_column_time for this? That filter is used by WP for posts and pages, as well as custom post types so it makes sense just to use the same filter for all of them.

[lopo]

I proposed a new filter for a number of related reasons:

• UI for media list and post list is different, we are talking of two different classes/files after all;
• defining the same hook in two different files can be misleading and poorly maintainable (if we ever have to change it, it will have to be done in both locations, etc.);
• in class-wp-posts-list-table.php the filter has a $mode parameter which is not defined for media:

  apply_filters( 'post_date_column_time', $h_time, $post, 'date', $mode )
  

• it's true that media are stored and managed as WP_Post objects, but they're quite different in various regards (they usually have inherit status, their post_date is usually set at upload and doesn't change...)
• it could happen that you want to use the hook for posts/pages/custom type items but not for media, and with two distinct hooks you can do it easily without having to resort to if/switch/whatever: for example when you are dealing with future posts, which makes no sense for media (I think it's one of the most likely use cases);
• conversely, if you want to hook the same function to both filters it can be done with just one line more.

[peterwilsoncc]

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

[desrosj]

This one still needs a review. It also feels like more of an Administration component request, so updating accordingly. Going to punt it so that the component maintainers can milestone it according to their ability to address this.

[lopo]

Patch refreshed

[lopo]

Patch refreshed

[lopo]

Patch refreshed

[audrasjb]

Moving for 6.0 consideration since the patch looks ready to ship.

[audrasjb]

The only suggestion I'd have would be to replace 6.0 with 6.0.0 in the docblock, otherwise it looks good to me :)

[lopo]

Patch updated after suggestion about version in Docblock

[lopo]

@audrasjb thanks for the suggestion, just applied

@antpb can you give some advice about or point me to someone who can? Thanks in advance!

[davidbaumwald]

In 52950:

Administration: Add a media_date_column_time filter to the media list table date column.

Similar to the existing post_date_column_time filter in the posts list table, this change adds a new hook to filter the "Date" column output in the media list view.

Props ivanlutrov, lopo, audrasjb.
Fixes #42942.

[davidbaumwald]

Marking needs-dev-note as this at least deserves a small mention in the Misc Dev Note.

[milana_cap]

As this is the only Administration ticket marked for docs it probably won't find a fitting Dev note so I'm marking it for mention in Field guide.