#42946 closed defect (bug) (wontfix)
Missing a space before inline comment text
| Reported by: | chetan200891 | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | General | Version: | 5.1 |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: | coding-standards |
Description
PHPCS gives an error.
'No space found before comment text;
So It needs a space before starting inline comment.
Attachments (2)
Change History (7)
#2
@
9 years ago
Thanks. Looking at the patch, the comment actually also needs a period at the end of the phrase.
#3
follow-up:
↓ 4
@
9 years ago
@jrf
Thanks for reply and suggestion. I have updated patch. 42946.1.diff
Apart from that, I have another question. There are still many inline comments in other files which gives error for "Inline comments must end in full-stops, exclamation marks, or question marks"
How are we going to fix that? Any planning for it?
#4
in reply to: ↑ 3
@
9 years ago
- Keywords has-patch removed
- Milestone Awaiting Review
- Resolution → wontfix
- Status new → closed
Closing this as SimplePie is an external 3rd party library that is included in WordPress and adheres to its own coding standards. Here's the exclusion: https://core.trac.wordpress.org/browser/trunk/phpcs.xml.dist#L33
Replying to chetan200891:
Apart from that, I have another question. There are still many inline comments in other files which gives error for "Inline comments must end in full-stops, exclamation marks, or question marks"
How are we going to fix that? Any planning for it?
Are these being reported by PHPCS using WordPress's phpcs.xml.dist file?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Created patch.