Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#42946 closed defect (bug) (wontfix)

Missing a space before inline comment text

Reported by: chetan200891's profile chetan200891 Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.1
Component: General Keywords:
Focuses: coding-standards Cc:

Description

PHPCS gives an error.

'No space found before comment text;

So It needs a space before starting inline comment.

Attachments (2)

42946.diff (630 bytes) - added by chetan200891 7 years ago.
Created patch.
42946.1.diff (631 bytes) - added by chetan200891 7 years ago.
Updated patch. Added period at the end.

Download all attachments as: .zip

Change History (7)

@chetan200891
7 years ago

Created patch.

#1 @chetan200891
7 years ago

  • Keywords has-patch added

#2 @jrf
7 years ago

Thanks. Looking at the patch, the comment actually also needs a period at the end of the phrase.

@chetan200891
7 years ago

Updated patch. Added period at the end.

#3 follow-up: @chetan200891
7 years ago

@jrf

Thanks for reply and suggestion. I have updated patch. 42946.1.diff

Apart from that, I have another question. There are still many inline comments in other files which gives error for "Inline comments must end in full-stops, exclamation marks, or question marks"

How are we going to fix that? Any planning for it?

Last edited 7 years ago by chetan200891 (previous) (diff)

#4 in reply to: ↑ 3 @netweb
7 years ago

  • Keywords has-patch removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing this as SimplePie is an external 3rd party library that is included in WordPress and adheres to its own coding standards. Here's the exclusion: https://core.trac.wordpress.org/browser/trunk/phpcs.xml.dist#L33

Replying to chetan200891:

Apart from that, I have another question. There are still many inline comments in other files which gives error for "Inline comments must end in full-stops, exclamation marks, or question marks"

How are we going to fix that? Any planning for it?

Are these being reported by PHPCS using WordPress's phpcs.xml.dist file?

#5 @jrf
7 years ago

Are these being reported by PHPCS using WordPress's phpcs.xml.dist file?

They wouldn't be (yet) as the WP-Docs ruleset is not (yet) included, quite apart from that ruleset not (yet) being feature complete.

Note: See TracTickets for help on using tickets.