Make WordPress Core

Opened 6 years ago

Last modified 2 years ago

#42952 new enhancement

Add comments about JS removal of message query_arg

Reported by: davidsword's profile davidsword Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.9.1
Component: Administration Keywords: needs-patch
Focuses: docs, administration Cc:

Description

This is a follow-up to #23367.

Can someone please add some inline doc about how Javascript actually removes &message=x from the URL - Specifically in /wp-admin/edit-form-advanced.php:186 (in WP 4.9.1).

As a plugin developer who looks up source code for solutions, I was wracking my brain around seeing $_GET['message'] as the main argument for showing admin notices, but never seeing it in backend. Took unnecessarily long time to figure out it actually exists and is just hidden.

Change History (1)

#1 @davidbaumwald
2 years ago

  • Component changed from Comments to Administration
  • Keywords needs-patch added

@davidsword Thanks for the ticket! This technically is not related to the Comments component and pertains to docs-type comments, which I think is what you're requesting. Setting the component to Administration so it can be picked up by that group.

Specifically looking at this issue, it seems the needs to document this a bit better was realized back in [25819].

Note: See TracTickets for help on using tickets.