WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#42975 closed defect (bug) (fixed)

Customize: Previewing a changeset locks the changeset

Reported by: dlh Owned by: westonruter
Milestone: 4.9.3 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

To demonstrate:

  1. Schedule or save a draft of a changeset.
  2. Close the Customizer.
  3. Visit the changeset preview link in another browser while logged in as a different user.
  4. Open the Customizer again as the first user, and see that the changeset has been locked by the second user.

This can be especially disorienting if the second user doesn't have access to the Customizer.

The attached patch attempts to address this issue by locking the changeset only when customize.php is being loaded. One downside to this approach is that it would mean anyone providing an alternate interface for editing a changeset would need to set the lock themselves, though.

Attachments (1)

42975.diff (768 bytes) - added by dlh 6 months ago.

Download all attachments as: .zip

Change History (10)

@dlh
6 months ago

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


6 months ago

#2 @westonruter
6 months ago

  • Milestone changed from Awaiting Review to 4.9.2

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


5 months ago

#4 @westonruter
5 months ago

  • Owner set to westonruter
  • Status changed from new to reviewing

#5 @dd32
5 months ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

This ticket was mentioned in Slack in #core by desrosj. View the logs.


5 months ago

#7 @westonruter
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 42541:

Customize: Prevent frontend previewing from causing a customization lock on the changeset.

Props dlh.
Amends [41839].
See #42024.
Fixes #42975.

#8 @westonruter
5 months ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @westonruter
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42542:

Customize: Prevent frontend previewing from causing a customization lock on the changeset.

Props dlh.
Amends [41839].
See #42024.
Fixes #42975 for 4.9 branch.

Note: See TracTickets for help on using tickets.