is_active_sidebar returns true on after plugin deactivation

[tpaksu]

Hi,

Steps to reproduce:

code:

<?php if(is_active_sidebar("custom-sidebar")) : ?>
    Sidebar is active, and it contains widget(s).
<?php else: ?>
    Sidebar doesn't contain any widget.
<?php endif;?>

1. Add a widget plugin to the custom-sidebar
2. Disable the widget plugin
3. Reload the page

The page is still showing sidebar is active. and wp_get_sidebars_widgets() still contains the disabled plugin's widget info.

Is this something intended? Or is it a bug?

[alexvorn2]

I think it is by design, so it checks in database if it has something inside, so that widget should get removed before or after plugin deactivation.

[tpaksu]

I solved it on my theme by using retrieve_widgets function which internally calls _wp_remove_unregistered_widgets that I think clears the inactive and disabled widgets from the database. But I don't feel comfortable with that solution that runs on every page render.

[westonruter]

Yeah, is_active_sidebar() should be more robust and check to see if the widgets in it are actually valid.

[mdifelice]

The retrieve_widgets() documentation says it has to run at least on each theme change. Should not be called when a plugin is deactivated too?