WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 7 days ago

#43031 closed defect (bug) (fixed)

Menu text is shown updated in collapsed widget though user has cancelled editing text

Reported by: nilamacharya Owned by: welcher
Milestone: 5.4 Priority: normal
Severity: normal Version: 4.9.1
Component: Menus Keywords: has-patch commit
Focuses: ui, javascript, administration Cc:

Description

Bug: Menu text is shown updated in collapsed widget though user has cancelled editing text

Steps:

Please check URL for steps: https://www.screencast.com/t/4vshm4i37G

  1. Navigate to Appearance->Menus from left rail
  2. Go to "Edit Menu" and add some menu in Menu structure at right side
  3. Expand Menu tab
  4. Edit Navigation Label for example from "Home" to "Home test"
  5. Select "Cancel" link , widgte is collapsed and updates text is display (which should not)
  6. Again expand and check Naviogation lable is not updated inside which is proper
  7. Try to edit text and now earlier updated text is removed.

Attachments (4)

menu text.png (97.2 KB) - added by nilamacharya 2 years ago.
menu text.mp4 (1.4 MB) - added by nilamacharya 2 years ago.
43031.patch (1.1 KB) - added by Girishpanchal 2 years ago.
Current menu label updated according to expanded menu navigation label.
menus-43031.mp4 (463.2 KB) - added by welcher 3 months ago.
Patch applied

Download all attachments as: .zip

Change History (15)

#1 @Girishpanchal
2 years ago

  • Focuses ui javascript administration added
  • Keywords has-patch added

We have 2 option to solve this bug.

  1. Either we need to update current expanded menu tab label according to the "Navigation Label"
  2. Update current expanded menu "Navigation Label" to menu tab label.

I think We should go with the second option "Update current expanded menu "Navigation Label" to menu tab label.".

Here is the patch.

Last edited 2 years ago by Girishpanchal (previous) (diff)

@Girishpanchal
2 years ago

Current menu label updated according to expanded menu navigation label.

#2 @melchoyce
2 years ago

  • Keywords ux-feedback added

This ticket was mentioned in Slack in #design by boemedia. View the logs.


16 months ago

#4 @JoshuaWold
16 months ago

We just discussed this in Slack. Wanted to share some UX feedback from the team:

  1. Can someone test the patch and validate the outcome?
  2. Agreed on the suggested path, just would love to see a screenshot showing the change.

#5 @JoshuaWold
16 months ago

  • Keywords needs-testing added; ux-feedback removed

#6 @welcher
3 months ago

The patch applies cleanly and I have tested locally.

@welcher
3 months ago

Patch applied

#7 @welcher
3 months ago

  • Keywords needs-testing removed
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to welcher
  • Status changed from new to assigned

@JoshuaWold I have tested this locally and uploaded an .mp4 to review.

#8 @JoshuaWold
3 months ago

@welcher great work! Based on the video the problem of the label not updating has resolved. Looks good from my perspective. 😀

#9 @audrasjb
2 weeks ago

@welcher we are now close to WP 5.4 beta 1. Could you please confirm the patch still applies cleanly and tag it for commit if you think it's worth having it in 5.4? Otherwise, if could be better to move it to 5.5 (maybe with early keyword). Thanks!

#10 @welcher
13 days ago

  • Keywords commit added

@audrasjb thanks for the ping on this! The patch applies fine for me.

#11 @SergeyBiryukov
7 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47294:

Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing.

Other inputs are already restored to their previous values in that case.

Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov.
Fixes #43031.

Note: See TracTickets for help on using tickets.