WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #43037, comment 31


Ignore:
Timestamp:
09/24/2019 01:26:39 PM (3 weeks ago)
Author:
ryokuhi
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43037, comment 31

    initial v1  
    11I wrote the patch and added the screenshots of the login page when new error messages are displayed.
    22
    3 In my opinion, there are some inconsistences in capitalization that should be solved before committing. The whole form uses title capitalization style, while the error messages use sentence capitalization style. There are two ways to solve this issue:
     3In my opinion, there are some inconsistences in capitalization that should be solved before committing. The whole form uses title case, while the error messages use sentence case. There are two ways to solve this issue:
    44* capitalize Username and Email Address in the error message (quick fix);
    5 * switch to sentence capitalization style in the form (needs a bit more time).
    6 I tend to think that title capitalization style is more difficult to read, so I'm more inclined towards changing the form instead. Checking for other tickets about capitalitazion, I found #47298 (already closed and included in 5.3 Beta 1) where, in a similar situation, it's stated that sentence case is more favorable in general. Maybe a discussion about capitalization style across the entire WordPress interface should be started in a new ticket.
     5* switch to sentence case in the form (needs a bit more time).
     6I tend to think that title case is more difficult to read, so I'm more inclined towards changing the form instead. Checking for other tickets about capitalitazion, I found #47298 (already closed and included in 5.3 Beta 1) where, in a similar situation, it's stated that sentence case is more favorable in general. Maybe a discussion about capitalization style across the entire WordPress interface should be started in a new ticket.
    77
    88As a side note about capitalitazion and the login form, I think that writing ERROR in all caps isn't particularly user friendly. Since Error is already included in a {{{strong}}} tag, capitalizing the first letter may be enough. As there are different ways to show error messages across the WordPress interface, reviewing and uniforming them might also be worth of a new ticket.