WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 10 of Ticket #43041


Ignore:
Timestamp:
10/12/2018 01:34:06 PM (7 years ago)
Author:
johnbillion
Comment:

I agree with Pento here. Renaming this function introduces backwards compatibility issues and is a breaking change. Deprecating it in favour of a better named function is more effort than it's worth.

Closing as fixed for 5.1 due to the sniffer comments introduced in [42429].

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #43041

    • Property Status changed from new to closed
    • Property Keywords has-patch added
    • Property Version changed from 4.9.1 to
    • Property Milestone changed from Awaiting Review to 5.1
    • Property Owner set to jrf
    • Property Resolution changed from to fixed

  • Ticket #43041 – Description

    initial v10  
    1 I'm not too bothered about the capital_P_dangit function in terms of what it does. Correcting Wordpress to WordPress is fine by me. Capitalise the `P` and it never worries you.
     1I'm not too bothered about the capital_P_dangit function in terms of what it does. Correcting WordPress to WordPress is fine by me. Capitalise the `P` and it never worries you.
    22
    33My problem with this function is the name and documentation of it. Taken from a 4.9.1 install: