WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #43055, comment 3


Ignore:
Timestamp:
01/09/2018 03:16:05 PM (3 years ago)
Author:
omarreiss
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43055, comment 3

    initial v1  
    44
    551) Stop allowing running from src and only build to `/build`.
    6 2) Allow running from src after a build step but .gitignore the built files.
     62) Allow running from src after a build step but `.gitignore` the built files.
    773) Allow running from src and commit the latest stable version of JS in src.
    88
    99The general consensus seems to be that we need to have a transition period in which we start out with option 3 and after some time transition to option 2 and/or option 1. I will do another iteration to make this possible.
    1010
    11 I would personally be in favor of `gitignoring` the built files from the start, because of the confusion that comes with having a set version of build files in the source. This can lead to a myriad of issues that I'd like to avoid. If we choose option 2 as the initial approach, the configuration / dev workflow impact would be minimal, while the gain would still be complete.
     11I would personally be in favor of gitignoring the built files from the start, because of the confusion that comes with having a set version of build files in the source. This can lead to a myriad of issues that I'd like to avoid. If we choose option 2 as the initial approach, the configuration / dev workflow impact would be minimal, while the gain would still be complete.