WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 5 months ago

#43058 new feature request

File search in theme & plugin editor window

Reported by: Mahesh901122 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch
Focuses: ui, administration Cc:

Description (last modified by afercia)

Now we have using Code mirror for updating theme/plugin files. We have also create a directory tree of theme & plugin files.

It is hard to search the file in the given directory tree. So, File search filed is useful to search particular file. This patch search file name & file extensions too.

Attachments (6)

screenshot-1[1].gif (93.4 KB) - added by Mahesh901122 5 months ago.
GIF of file search.
43058.patch (2.2 KB) - added by Mahesh901122 5 months ago.
File search patch
43058.2.patch (2.2 KB) - added by dilipbheda 5 months ago.
Coding Standard Improvement
43058-3.patch (3.8 KB) - added by Mahesh901122 5 months ago.
Handle UI & Accessibility.
ui-and-accessibility-fix.gif (133.1 KB) - added by Mahesh901122 5 months ago.
UI and Accessibility Fix
43058.4.patch (3.4 KB) - added by dilipbheda 5 months ago.
Coding Standard Updated

Download all attachments as: .zip

Change History (12)

@Mahesh901122
5 months ago

GIF of file search.

@Mahesh901122
5 months ago

File search patch

#1 @dilipbheda
5 months ago

I have made changes to existing .patch to improve coding standard.

  1. Expected 1 space before/after closing bracket.

@dilipbheda
5 months ago

Coding Standard Improvement

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 months ago

#3 @afercia
5 months ago

  • Component changed from Editor to Plugins
  • Description modified (diff)
  • Focuses accessibility removed
  • Version trunk deleted

@Mahesh901122 and @dilipbheda thanks for the patch! Looks like an interesting proposal! Discussed a bit during today's accessibility team bug-scrub, and probably this is something the UI team would like to consider. A couple accessibility things:

  • the search field misses a label
  • this kind of filtering with suggestions should be made accessible following the pattern already used in core for similar cases, see for example the links suggestions and the tags suggestions

@Mahesh901122
5 months ago

Handle UI & Accessibility.

@Mahesh901122
5 months ago

UI and Accessibility Fix

#4 @afercia
5 months ago

  • Description modified (diff)

My bad, I've changed the original description by mistake.

For reference, the files "tree" was introduced in [41851], see #24048.

#5 @dilipbheda
5 months ago

  • Focuses coding-standards added
  • Keywords has-patch added

@Mahesh901122 Every time you have missed coding standard of WordPress when you patch. Please make sure next time when you patch WordPress.

I have made changes to existing .patch to improve coding standard.

  1. Expected 1 space before/after closing bracket.
  2. You have added variable above the commenting section

@dilipbheda
5 months ago

Coding Standard Updated

#6 @jrf
5 months ago

  • Focuses coding-standards removed
Note: See TracTickets for help on using tickets.