WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 20 months ago

#43066 closed enhancement (fixed)

Improve JS Documentation: password-strength-meter.js

Reported by: jjcomack Owned by: atimmer
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch
Focuses: javascript, docs Cc:

Description

In our ongoing effort to improve JavaScript documentation, this patch adds descriptions and JSDoc formatting to the following file:

password-strength-meter.js

Please give props to:

Attachments (3)

password-strength-meter.diff (3.2 KB) - added by jjcomack 2 years ago.
document-password-strength.diff (21.2 KB) - added by jjcomack 2 years ago.
password-strength-meter.2.diff (3.2 KB) - added by jjcomack 2 years ago.

Download all attachments as: .zip

Change History (11)

#1 follow-up: @swissspidy
2 years ago

  • Focuses javascript docs added
  • Keywords has-patch added

Just noticed this on the last line of the patch. We spell it backward compatibility, not backwards compatibility.

See https://make.wordpress.org/core/handbook/glossary/

#2 in reply to: ↑ 1 @netweb
2 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to atimmer
  • Status changed from new to assigned

Replying to swissspidy:

Just noticed this on the last line of the patch. We spell it backward compatibility, not backwards compatibility.

See https://make.wordpress.org/core/handbook/glossary/

I've added needs-refresh per the above @jjcomack, could you refresh the patch with this change please.

#3 follow-up: @jjcomack
2 years ago

Attached a newer version. Alas, I forgot to rename the file prior to uploading, so you need to look at the document-password-strength.diff file

#4 in reply to: ↑ 3 @netweb
2 years ago

Replying to jjcomack:

Attached a newer version. Alas, I forgot to rename the file prior to uploading, so you need to look at the document-password-strength.diff file

There's a few unrelated changes in the document-password-strength.diff patch @jjcomack, it looks like your repo needs updating from master

#5 @jjcomack
2 years ago

@netweb Sorry about that. I believe that the latest file should now be correct.

#6 @netweb
2 years ago

Thanks @jjcomack, looks good +1

#7 @atimmer
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42528:

Docs: Improve JSDoc for password-strength-meter.js.

Props herregroen, carolinegeven, ireneyoast, jjcomack.
Fixes #43066.

#8 @johnbillion
20 months ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.