#43066 closed enhancement (fixed)
Improve JS Documentation: password-strength-meter.js
Reported by: | jjcomack | Owned by: | atimmer |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Login and Registration | Keywords: | has-patch |
Focuses: | javascript, docs | Cc: |
Description
In our ongoing effort to improve JavaScript documentation, this patch adds descriptions and JSDoc formatting to the following file:
password-strength-meter.js
Please give props to:
Attachments (3)
Change History (11)
#2
in reply to:
↑ 1
@
7 years ago
- Milestone changed from Awaiting Review to 5.0
- Owner set to atimmer
- Status changed from new to assigned
Replying to swissspidy:
Just noticed this on the last line of the patch. We spell it backward compatibility, not backwards compatibility.
I've added needs-refresh
per the above @jjcomack, could you refresh the patch with this change please.
#3
follow-up:
↓ 4
@
7 years ago
Attached a newer version. Alas, I forgot to rename the file prior to uploading, so you need to look at the document-password-strength.diff
file
#4
in reply to:
↑ 3
@
7 years ago
Replying to jjcomack:
Attached a newer version. Alas, I forgot to rename the file prior to uploading, so you need to look at the
document-password-strength.diff
file
There's a few unrelated changes in the document-password-strength.diff patch @jjcomack, it looks like your repo needs updating from master
Just noticed this on the last line of the patch. We spell it backward compatibility, not backwards compatibility.
See https://make.wordpress.org/core/handbook/glossary/