WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #43076, comment 2


Ignore:
Timestamp:
01/28/2019 08:18:42 PM (6 months ago)
Author:
audrasjb
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43076, comment 2

    initial v1  
    11Hi and thanks for the ticket and you patch,
    22
    3 I think the patch will need some refresh and some correction to fit better with WPCS. However, I'm not sure it's 100% relevant to add `current-menu-item` class to archive page when we are in a singular Post: the Post can appear in different taxonomy terms and the post can also appear in the menu items.
     3I think the patch will need some refresh and some correction to fit better with WPCS. However, I'm not sure it's 100% relevant to add `current-menu-item` class to archive page when we are in a singular Post: the Post may belong to different taxonomy terms and also, the singular Post itself may appear in the menu items.