Deregistering WP_Widget_Media_Image breaks Text widget's "Add Media" button

[standardspace]

Using:

<?php
unregister_widget( 'WP_Widget_Media_Image' );

results in Text widget's "Add Media" button no longer working.

[swissspidy]

Hey there

Welcome to WordPress Trac!

I cannot reproduce this using

add_action( 'widgets_init', function() {
        unregister_widget( 'WP_Widget_Media_Image' );
} );

The "Add Media" button in the text widget is still there and I can successfully upload and insert images to the text widget.

Have you tried disabling all plugins and using a default theme to see if the error persists?

[standardspace]

Hi,
Thanks for quick response.
I'll set up a clean install now and let you know.

[standardspace]

You're correct.

Sorry, I could have tried it with a standard theme. I guess the bug is with my code.

Please feel free to close.

[standardspace]

I've investigated further and found that the "Add Media" button fails unless one of the Media widgets is active.

Adding this to the Twenty Seventeen theme:

<?php
add_action( 'widgets_init', function() {
   unregister_widget( 'WP_Widget_Media_Image' );
   unregister_widget( 'WP_Widget_Media_Audio' );
   unregister_widget( 'WP_Widget_Media_Video' );
   unregister_widget( 'WP_Widget_Media_Gallery' );
} );

causes the "Add Media" button to fail.

Looks like the required javascript may not be loaded when there are no "media" widgets present. This leaves the Text widget without the add media functionality.

[swissspidy]

Indeed. I just tested this using ​WP Widget Disable and am getting the same result now. That's certainly unexpected.

Adding to the 4.9.3 milestone for visibility, but needs a patch to get into that release.

[westonruter]

@standardspace would you please try 43125.0.diff​?

[standardspace]

Hi Weston,
I've tested that on a clean wp install all seems to work as I would expect.

I've added the following to my functions.php :

<?php
add_action( 'widgets_init', function() {
    unregister_widget( 'WP_Widget_Media_Image' );
    unregister_widget( 'WP_Widget_Media_Audio' );
    unregister_widget( 'WP_Widget_Media_Video' );
    unregister_widget( 'WP_Widget_Media_Gallery' );
} );

and the Text widget's "Add Media" was able to function without the other media widgets present.

Looks like a fix. Thanks

[westonruter]

In 42545:

Widgets: Ensure media is explicitly enqueued from Text widget in case Media widgets are unregistered.

Amends [41344].
See #40854.
Fixes #43125.

[westonruter]

In 42546:

Widgets: Ensure media is explicitly enqueued from Text widget in case Media widgets are unregistered.

Amends [41344].
See #40854.
Fixes #43125 for 4.9 branch.