WordPress.org

Make WordPress Core

Opened 21 months ago

Last modified 21 months ago

#43126 new defect (bug)

Lang File in wp-includes/js/mediaelement

Reported by: adrianhead1 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.9.2
Component: Upgrade/Install Keywords: reporter-feedback
Focuses: Cc:
PR Number:

Description

It appears that a Lang Folder is being added to the above resulting in a whole language list appearing. It is not contained in the downloaded 4.9.2 on WP Org but seems to occur when the site is automatically updated.

Does not appear to cause a problem just should not be there and is being reported by Wordfence and similar plugins that monitor core files

Change History (6)

#1 @dd32
21 months ago

  • Component changed from General to Upgrade/Install
  • Keywords reporter-feedback added

Hi @adrianhead1,

The lang folder was included in 4.9 and 4.9.1. It was supposed to be removed in 4.9.2.

A few quick questions:

  • Do you have wp-includes/js/mediaelement/mediaelement-flash-audio-ogg.swf on the system?
  • What size are the files in the lang folder?
  • What version of WordPress were you previously running 4.9.1?
  • How was the update performed? Automatically by WordPress, or manually by you clicking the update button, or perhaps by another software package (such as hosts control panels)

#2 follow-up: @adrianhead1
21 months ago

Below is a list of all the files. The updates were automatic either by the host or by clicking the auto update on the dashboard. Previous versions in all cases were 4.9.1 So it looks as though the update to 4.9.2.just failed to remove the previous files no longer required. I have updated manually now to remove them.

  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/ca.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/cs.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/de.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/es.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/fa.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/fr.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/hr.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/hu.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/it.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/ja.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/ko.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/nl.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/pl.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/pt.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/ro.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/ru.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/sk.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/sv.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/uk.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/zh-cn.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/lang/zh.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/mediaelement-flash-audio-ogg.swf
  • Unknown file in WordPress core: wp-includes/js/mediaelement/mediaelement-flash-audio.swf
  • Unknown file in WordPress core: wp-includes/js/mediaelement/mediaelement-flash-video-hls.swf
  • Unknown file in WordPress core: wp-includes/js/mediaelement/mediaelement-flash-video-mdash.swf
  • Unknown file in WordPress core: wp-includes/js/mediaelement/mediaelement-flash-video.swf
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/dailymotion.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/dailymotion.min.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/facebook.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/facebook.min.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/soundcloud.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/soundcloud.min.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/twitch.js
  • Unknown file in WordPress core: wp-includes/js/mediaelement/renderers/twitch.min.js

#3 in reply to: ↑ 2 @dd32
21 months ago

Replying to adrianhead1:

Below is a list of all the files. The updates were automatic either by the host or by clicking the auto update on the dashboard. Previous versions in all cases were 4.9.1 So it looks as though the update to 4.9.2.just failed to remove the previous files no longer required. I have updated manually now to remove them.

Thanks for that, however can you please clarify how the updates were performed?
Specifically, Did you have to click a button to initiate the update, or was it performed "automatically" (without ANY input from you, no clicking buttons either in WordPress or in your hosts panel to do the update).

When you do perform updates manually, does it ask for FTP credentials?

It sounds like the deletions simply weren't accepted by your host at the time of the update, I'd be curious if this works:

  • Re-create one of the files (Any file from your above comment, with any content)
  • Go to Dashboard -> Updates -> Click Reinstall
  • See if the file you just created has been deleted

It it isn't deleted, then there's something happening between WordPress and the server which I can't duplicate and can't diagnose without duplicating, If it is deleted, then either the original upgrade to 4.9.2 was incomplete or the deletions didn't take on the server (even though WordPress thought they had).

#4 @adrianhead1
21 months ago

Updates were performed in 2 different ways. One where WordPress is set-up to automatically update and where on another site I clicked the update button on the WP Dashboard. 4 sites were auto updated and 1 via the dashboard update button. All resulted in the same result. The lang file remained in place as did the files relating to flash etc.

I will do a test tomorrow as you requested as it is a bit late here where I am and update you as to the result, but as upgrading one of the sites via the dashboard upgrade button did not result in the files and lang folder being removed it seems something did not work as it should. The sites are also on different hosts so is not a single host problem.

#5 @dd32
21 months ago

Are all these sites using English as the locale?

I've just run tests on all the environments I have access to and deletions are working as expected for me.

If you could email me at dion@… with the url for one of the affected sites, I'd appreciate it so i can take a quick look at a few things.

#6 @FeralReason
21 months ago

Wordfence also flagged my site for the same files. I did a simple "reinstall now" of 4.9.2–en and reran the scan. That apparently got rid of them.

Last edited 21 months ago by FeralReason (previous) (diff)
Note: See TracTickets for help on using tickets.