Context Navigation

Changes between Version 1 and Version 2 of Ticket #43159, comment 1

v1	v2
5	5	I reviewed [attachment:43159.diff] and here are some notes:
6	6
7		- I don't think we should add {{{wp_doing_xmlrpc()}}} in that line in {{{wp-cron.php}}}, because that file can be ~~called directly, (see e.g. {{{spawn_cron()}}}) and then {{{wp_doing_xmlrpc()}}} wouldn't be defined and resulting in a PHP error~~.
	7	- I don't think we should add {{{wp_doing_xmlrpc()}}} in that line in {{{wp-cron.php}}}, because that file can be requested directly, (see e.g. within {{{spawn_cron()}}} [https://core.trac.wordpress.org/browser/tags/4.9/src/wp-includes/cron.php#L353 here] ) and then {{{wp_doing_xmlrpc()}}} wouldn't be defined and resulting in a PHP error. Some users rely on Unix Cron instead, requesting that file from there.
8	8	- It removes the {{{\|\| defined( 'DOING_AJAX' )}}} check in {{{is_admin_bar_showing()}}}. I think that removal must have been accidental and should be reverted.
9	9	- I found an extra {{{defined( 'XMLRPC_REQUEST' )}}} check in {{{spawn_cron()}}} ([https://core.trac.wordpress.org/browser/tags/4.9/src/wp-includes/cron.php#L275 src]), but I noticed that {{{defined( 'DOING_AJAX' )}}} and {{{defined( 'DOING_CRON' )}}} have not been replaced. Most likely a reason for that, but we could look further into that.