WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#43190 closed defect (bug) (fixed)

Update prefixed CSS properties in about.css

Reported by: afercia's profile afercia Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

On a clean, updated, trunk install:

  • modify some CSS file so that postcss:core will run during grunt precommit
  • run grunt precommit
  • you will get a modified src/wp-admin/css/about.css file with some -moz prefixed properties removed

These changes should be committed to avoid unrelated changes in other commits.

Attachments (1)

43190.diff​ (565 bytes) - added by netweb 7 years ago.

Download all attachments as: .zip

Change History (7)

#1 @afercia
7 years ago

  • Summary changed from Update prefixed SS properties in about.css to Update prefixed CSS properties in about.css

@netweb
7 years ago

#2 @netweb
7 years ago

  • Keywords has-patch commit added; needs-patch removed

At first glance, I thought this was a follow up to [42181] that was missed in the build process somehow.

Rather it's a change in behaviour via Autoprefixer/Browserslist configuration. Firefox v51 (the current is v58) requires the -moz-column-count: 2; prefix, column-count was ​added to Firefox v52 so I'm not sure as to why Autoprefixer/Browserslist is only fixing this now, I've spent 15 minutes looking and the rabbit hole is deep!

Let's get this in ASAP to "avoid unrelated changes in other commits" as @afercia has noted

#3 @dd32
7 years ago

  • Milestone changed from 4.9.4 to 4.9.5

Bumping, 4.9.4 has been released.

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42687:

Build/Test Tools: Update prefixed CSS properties in about.css.

Firefox 52+ supports unprefixed column-count and column-gap properties.

Props netweb, afercia.
Fixes #43190.

#5 @SergeyBiryukov
7 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.9.5 consideration.

#6 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42802:

Build/Test Tools: Update prefixed CSS properties in about.css.

Firefox 52+ supports unprefixed column-count and column-gap properties.

Props netweb, afercia.
Merges [42687] to the 4.9 branch.
Fixes #43190.

Note: See TracTickets for help on using tickets.