PHP Warning: count(): Parameter must be an array or an object that implements Countable in /wp-includes/media.php on line 1206

[codegrau]

PHP Warning:

count(): Parameter must be an array or an object that implements Countable in /wp-includes/media.php on line 1206

[SergeyBiryukov]

Hi @codegrau, welcome to WordPress Trac! Thanks for the report.

This sounds like a plugin incorrectly using the wp_calculate_image_srcset filter and returning a non-array. That said, we should make sure $sources is an array before calling count().

[mrmadhat]

Added a patch that checks $sources is an array before calling count()

[SergeyBiryukov]

In 42639:

Media: Avoid a PHP warning in wp_calculate_image_srcset() if a plugin returns a non-array value via wp_calculate_image_srcset filter.

Props mrmadhat, codegrau.
Fixes #43201.

[SergeyBiryukov]

Reopening for 4.9.4 consideration.

[dd32]

Bumping, 4.9.4 has been released.

[SergeyBiryukov]

In 42669:

Media: Avoid a PHP warning in wp_calculate_image_srcset() if a plugin returns a non-array value via wp_calculate_image_srcset filter.

Props mrmadhat, codegrau.
Merges [42639] to the 4.9 branch.
Fixes #43201.