Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#43220 closed defect (bug) (fixed)

CSS Coding standards: Use double quotes for values

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:


As per the CSS Coding standards:

Use double quotes rather than single quotes, and only when needed, such as when a font name has a space.

Specifically, for CSS generated content (especially icons) there are good reasons to always use double quotes, see [34011] / #33786. Even when the icons don't have to be swapped for RTL, using double quotes it's always a good practice.

I'd also propose to update the Coding Standards page to explicitly mention values for the content property.

Attachments (2)

43220.diff (2.7 KB) - added by afercia 6 years ago.
43220.2.diff (8.1 KB) - added by afercia 6 years ago.

Download all attachments as: .zip

Change History (7)

6 years ago

#1 @afercia
6 years ago

  • Keywords has-patch added

6 years ago

#2 @afercia
6 years ago

43220.2.diff fixes also some indentation and double spaces in the touched files.

#3 @afercia
6 years ago

  • Milestone changed from Awaiting Review to 5.0

#4 @afercia
6 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 42641:

Administration: CSS coding standards: use double quotes for values that require quotes.

As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.

#5 @pento
6 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.