Make WordPress Core

Opened 7 years ago

Closed 3 months ago

Last modified 3 months ago

#43225 closed enhancement (fixed)

feed_links and feed_links_extra should have filters

Reported by: topdownjimmy's profile topdownjimmy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Feeds Keywords: has-patch
Focuses: template Cc:

Description

There ought to be a way to modify the way feed links are displayed by the feed_links function. Currently there is, for instance, no way to change the separator from » to something else.

Attachments (4)

43225.patch (410 bytes) - added by topdownjimmy 7 years ago.
43225.2.patch (631 bytes) - added by topdownjimmy 7 years ago.
43225.3.patch (933 bytes) - added by topdownjimmy 7 years ago.
43225.4.patch (933 bytes) - added by topdownjimmy 7 years ago.

Download all attachments as: .zip

Change History (13)

@topdownjimmy
7 years ago

#1 @topdownjimmy
7 years ago

  • Summary changed from feed_links should have filter to feed_links and feed_links_extra should have filters

#2 @williampatton
7 years ago

  • Keywords has-patch needs-docs added

Could a comment be added above the filters to indicate that they are new?

Last edited 7 years ago by williampatton (previous) (diff)

#3 @SergeyBiryukov
7 years ago

Yes, new filters need to be documented as per the documentation standards.

#4 @pento
6 years ago

  • Version trunk deleted

This ticket was mentioned in PR #7100 on WordPress/wordpress-develop by @tw2113.


3 months ago
#5

This code change updates original changes from the trac ticket below, to match the current code from WordPress Trunk. Everything should match what the original patch submitter added, with the exception of a touch of extra punctuation with the PHPDoc block and the version. Once the PR is ready to be accepted, I can update the NEXT value for the accepted release version.

Trac ticket: See https://core.trac.wordpress.org/ticket/43225

#6 @tw2113
3 months ago

  • Keywords needs-docs removed

Issued a PR on Github to refresh @topdownjimmy's original work.

#7 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 58821:

Feeds: Introduce feed_links_args and feed_links_extra_args filters.

This allows for more flexibility in modifying how feed links are displayed by the feed_links() and feed_links_extra() functions, including, for example, a way to change the » separator to something else.

Follow-up to [10377], [33838], [33839], [53125], [54161].

Props topdownjimmy, tw2113, williampatton.
Fixes #43225.

#8 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 6.7

@SergeyBiryukov commented on PR #7100:


3 months ago
#9

Thanks for the PR! Merged in r58821.

Note: See TracTickets for help on using tickets.