Crop setting in thumbnails never set when uploading PDF files

[leemon]

I don't know if it's specific to my server config but, for some reason, the crop setting in thumbnails is never set when I upload PDF files.

Apparently, the following conditional statement in the /wp-admin/includes/image.php file is never true when it's supposed to run for medium and large thumbnails:

https://core.trac.wordpress.org/browser/tags/4.9/src/wp-admin/includes/image.php#L244

If I remove the conditional statement the crop setting is set for all thumbnails.

I'm using WordPress 4.9.2 with PHP 7.0.27

[leemon]

If I change the conditional statement to:

if ( 'thumbnail' !== $s ) {
    $sizes[ $s ]['crop'] = get_option( "{$s}_crop" );
}

it works as expected.

[SergeyBiryukov]

Hi @leemon, welcome to WordPress Trac! Thanks for the report.

Yes, the current ! 'thumbnail' === $s condition doesn't appear to work as expected. It's only satisfied if $s is boolean false. It should indeed be 'thumbnail' !== $s.

[SergeyBiryukov]

Introduced in [38949].

[chetan200891]

Unit test.

[chetan200891]

Attached Unit Test patch 43226-unit-test.diff

The smallest thumbnail size was specifically excluded from forced cropping, but that the patch would fix it so that the other sizes would honor the forced cropping.

[birgire]

I tested 43226.diff​ and 43226-unit-test.diff​ but the unit-test failed.

It ran successfully when I changed:

'medium'    => array(
	'file'      => 'wordpress-gsoc-flyer-pdf-232x300.jpg',
	'width'     => 300,
	'height'    => 300,
	'mime-type' => 'image/jpeg',
),

to:

'medium'    => array(
	'file'      => 'wordpress-gsoc-flyer-pdf-300x300.jpg',
	'width'     => 300,
	'height'    => 300,
	'mime-type' => 'image/jpeg',
),

Ticket #39975 aims to Remove direct calls to '/tmp/' in Unit Tests.

So 43226.2.diff​ uses get_temp_dir() instead of '/tmp/'.

If we want to use:

$test_file = wp_tempnam( 'wordpress-gsoc-flyer.pdf' );

then we have to deal with files like:

/tmp/wordpress-gsoc-flyer-Y5yoVa.tmp

making it a little more involved to create the $expected array and then to unlink the corresponding files.

[kirasong]

In 42792:

Media: Correctly allow changing PDF thumbnail crop value.

Corrects logic that keeping plugins from setting crop value of intermediate image sizes for rendered PDFs.

Adds test.

Props leemon, SergeyBiryukov, chetan200891, birgire.
Fixes #43226.

[kirasong]

Reopening for 4.9.5 consideration

[kirasong]

In 42813:

Media: Correctly allow changing PDF thumbnail crop value.

Corrects logic that kept plugins from setting crop value of intermediate image sizes for rendered PDFs.
Adds test.

Props leemon, SergeyBiryukov, chetan200891, birgire.
Merges [42792] to the 4.9 branch.
Fixes #43226.