WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 10 days ago

#43242 closed enhancement (fixed)

Do not propose users to skip a minor upgrade

Reported by: casiepa Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 4.9.3
Component: Upgrade/Install Keywords: has-patch needs-testing
Focuses: Cc:
PR Number:

Description

1) When having a non-US installation and a new version of WP gets proposed, the text is indicating 'You can skip upgrading if you want to keep your current translation'. I think it's a bad idea to tell people they can skip upgrading.

Most probably it would be better to indicate that there might be temporarily some translation issues if the translation files are not immediately available.

2) The button says 'Hide this update', the text says 'skip'. Probably better to harmonize (if these are linked, which I think they are).

Attachments (2)

skip_upgrade.PNG (15.4 KB) - added by casiepa 2 years ago.
Hide-Skip upgrade
43242.diff (1.2 KB) - added by danieltj 2 years ago.
Changed the string

Download all attachments as: .zip

Change History (13)

@casiepa
2 years ago

Hide-Skip upgrade

#1 @danieltj
2 years ago

Agree, generally users shouldn't be skipping updates and in most cases, with updates, either major or minor, there's not always a huge amount of strings to translate so it's not as if the entire translation package becomes obsolete. Definitely in favour of addressing such a thing.

This ticket was mentioned in Slack in #core-i18n by casiepa. View the logs.


2 years ago

@danieltj
2 years ago

Changed the string

#5 @danieltj
2 years ago

  • Keywords has-patch needs-testing added

I've updated the string under the buttons. My personal opinion is that whilst keeping the hide button is fine, I don't think we should be actively saying people can skip the update if they want to. I don't think that's a good idea in any case. I've also reworded the first part of the string to explain that it contains a translation set for the current locale as in some instances, updates won't contain translation updates as there aren't any.

#6 @tobifjellner
2 years ago

@danieltj You wrote: This localized version of the update contains a set of translations for your preferred locale.
Perhaps better to say: This localized version of the update contains an updated set of translations for your selected locale and may also contain some additional adaptations that may be needed for your language.
What do you think?

#7 @casiepa
2 years ago

@tobifjellner Even if the translations are not updated, the update will (and should) still be proposed. Having the translations updated and having the update ready are (to me) 2 different things.

But I could agree with the 'and may also contain some additional adaptations...'

#8 @tobifjellner
2 years ago

or ... up-to-date translation set... ?

#9 @netweb
2 years ago

I think the functionality should stay as is, perhaps just a tweak to the second sentence of that string:

From:

You can skip upgrading if you want to keep your current translation.

To:

You can upgrade to the en-US localized version instead if you would prefer to maintain your current translations.

FWIW: Minor updates are typically updated automatically (except for those who have these updates disabled), so seeing this screen is an abnormality for most users and fingers crossed most will never see this screen again

#10 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Related: [25784] / #18200.

With the introduction of asynchronous translation updates in #18200, I think the "keep your current translation" part is no longer relevant. Let's just remove the second sentence entirely.

#11 @SergeyBiryukov
10 days ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47061:

Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation.

With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.

Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242.

Note: See TracTickets for help on using tickets.