Extra tabs when quick editing a comment

[SergeyBiryukov]

When quick editing a comment, there are 4 extra tabs in the textarea: 2 before the comment content and 2 after.

Caused by [42343], which changed this:

		<textarea class="comment" rows="1" cols="1"><?php
			/** This filter is documented in wp-admin/includes/comment.php */
			echo esc_textarea( apply_filters( 'comment_edit_pre', $comment->comment_content ) );
		?></textarea>

to this:

		<textarea class="comment" rows="1" cols="1">
		<?php
			/** This filter is documented in wp-admin/includes/comment.php */
			echo esc_textarea( apply_filters( 'comment_edit_pre', $comment->comment_content ) );
		?>
		</textarea>

Might be a good idea to review other <textarea> instances in core as well.

[chetan200891]

Created patch 43252.diff to remove 4 extra tabs in textarea.

[jrf]

I agree this should be reverted and shouldn't have been changed in the first place, however, it was changed because of an underlying issue, i.e. HTML entities not being escaped in the text being passed to the editor.

IMO, the patch should be updated to properly escape the entities, like below:

---

Actually, I was too quick in my response and missed that the textarea wasn't intended to display the php code for editing. Sorry about that.

So, reboot.

Looking at the code properly, IMO, it should be changed as follows:

		<?php
		/** This filter is documented in wp-admin/includes/comment.php */
		$filtered_comment = apply_filters( 'comment_edit_pre', $comment->comment_content );
		?>

		<textarea class="comment" rows="1" cols="1"><?php echo esc_textarea( $filtered_comment ); ?></textarea>

Or alternatively, don't bother with the inline HTML at all:

<?php
                <?php
                echo '<textarea class="comment" rows="1" cols="1">';
                /** This filter is documented in wp-admin/includes/comment.php */
                echo esc_textarea( apply_filters( 'comment_edit_pre', $comment->comment_content ) );
                echo '</textarea>';

[ocean90]

@jrf I think you misread the code somehow. We don't want the PHP code displayed in the textarea, it should be the comment content.

[jrf]

Replying to ocean90:

@jrf I think you misread the code somehow. We don't want the PHP code displayed in the textarea, it should be the comment content.

Yup, already edited my original response. Sorry about that ;-)

[chetan200891]

@jrf Thanks for your suggestion. I have updated patch!

[jrf]

@chetan200891 👍

Looking at the complete function, I think the setting of the variable/apply_filters() function call could even be moved up a little more to just below the if ( $this->user_can ) {.
That way, the HTML block looks cleaner, but it's no biggy.

[chetan200891]

Yeah @jrf You are right. Updated patch. It looks now more cleaner! :)

[SergeyBiryukov]

In 42670:

Comments: Avoid extra tabs in a textarea in WP_Comments_List_Table::column_comment().

Props chetan200891, jrf.
Fixes #43252.

[SergeyBiryukov]

In 42671:

Options: Avoid extra tabs in a textarea in wp-admin/options.php.

See #43252.

[SergeyBiryukov]

In 42672:

Upgrade/Install: Avoid extra line breaks in a textarea in wp-admin/setup-config.php.

See #43252.

[SergeyBiryukov]

In 42673:

Customize: Avoid extra tabs in a textarea in WP_Customize_Control::render_content().

See #43252.

[SergeyBiryukov]

In 42674:

Posts, Post Types: Remove extra tabs around page_attributes_meta_box_template action in page_attributes_meta_box().

Props chetan200891.
See #43252.

[SergeyBiryukov]

The issues here were caused by [42343] and are only relevant for 5.1.