WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 15 months ago

Last modified 15 months ago

#43253 closed defect (bug) (fixed)

Insert Link Dialog captures shift+arrow and changes selected item rather than highlighting text

Reported by: garrett-eclipse Owned by: desrosj
Milestone: 5.0.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch fixed-major
Focuses: ui, accessibility Cc:

Description

Hello,

Often when I want to edit a text field I click in the middle and hold shift+up/down to highlight all text before/after where my cursor is.
When you're in the Insert Link popup modal and try to do this in the Link Text then your selected page from the search list changes. This initially threw me and I ended up changes links by accident.

Can the up/down only change the selected page if you're not focused on another input or maybe have it do nothing when shift is held down.

Thanks

Attachments (2)

Screen Shot 2018-02-07 at 3.51.01 PM.png (51.3 KB) - added by garrett-eclipse 2 years ago.
Insert Link Modal
43253.diff (426 bytes) - added by afercia 2 years ago.

Download all attachments as: .zip

Change History (17)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

#2 @afercia
2 years ago

  • Component changed from TinyMCE to Editor
  • Milestone changed from Awaiting Review to 5.0
  • Version 4.9.4 deleted

Seems simple enough to improve, probably there's the need to check what happens in the inline link toolbar too.

@afercia
2 years ago

#3 @afercia
2 years ago

  • Keywords has-patch added

43253.diff prevents to trigger links selection when the ShIft key is used.

#4 @afercia
2 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 42807:

Accessibility: Insert Link modal: Improve keyboard interaction.

Avoids to change the selected link when using the Shift and Up/Down arrow keys
to select text in the form fields.

Fixes #43253.

#5 @johnbillion
18 months ago

  • Milestone changed from 5.0 to 5.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

#6 @afercia
18 months ago

  • Owner afercia deleted
  • Status changed from reopened to assigned

#7 @pento
16 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#8 @pento
16 months ago

  • Milestone changed from 5.0.2 to 5.0.3

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


15 months ago

#10 @audrasjb
15 months ago

  • Keywords fixed-major added

#11 @desrosj
15 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from assigned to closed

In 44405:

Accessibility: Insert Link modal: Improve keyboard interaction.

Avoids change the selected link when using the Shift + Up/Down arrow keys
to select text in the form fields.

Props afercia.

Merges [42807] to the 5.0 branch.
Fixes #43253.

#12 follow-up: @afercia
15 months ago

@desrosj as far as I see, this is fixed and released in 5.0. The related file is now src/js/_enqueues/lib/link.js. Not sure why it's still milestoned for 5.0.3.

#13 in reply to: ↑ 12 @SergeyBiryukov
15 months ago

Replying to afercia:

@desrosj as far as I see, this is fixed and released in 5.0. The related file is now src/js/_enqueues/lib/link.js.

I don't see this change in 5.0. src/js/_enqueues/ only exists in trunk, doesn't it?

#14 @desrosj
15 months ago

From what I can tell, it was not included in 5.0. 5.0 was branched from the 4.9 branch, and the only commit was [42807], which was to trunk. [44405] earlier today finally merged it into 5.0 for inclusion in 5.0.3. Not sure if I missed something.

#15 @afercia
15 months ago

I see. Sorry, all this is terribly confusing.

Note: See TracTickets for help on using tickets.