WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#43259 closed defect (bug) (invalid)

Extra tabs in meta-boxes.php

Reported by: chetan200891 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: coding-standards Cc:

Description

There are too many extra tabs found in wp-admin/includes/meta-boxes.php

Attachments (1)

43259.diff (4.5 KB) - added by chetan200891 3 years ago.
Created patch to remove extra tabs.

Download all attachments as: .zip

Change History (5)

@chetan200891
3 years ago

Created patch to remove extra tabs.

#1 @chetan200891
3 years ago

  • Keywords has-patch added

Attached patch 43259.diff to remove extra tabs from wp-admin/includes/meta-boxes.php

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.0

#3 @johnbillion
3 years ago

  • Milestone changed from 5.0 to 5.1

#4 @pento
3 years ago

  • Milestone 5.1 deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Version trunk deleted

I agree that this is indented incorrectly, but it can't be fixed with a patch, as it'll simply be re-indented the next time composer run format is run on that file.

This needs to be fixed by improving the structure of the code (less interpolation of PHP and HTML), or changing the auto-fixer behaviour in WPCS or PHPCS.

I'm going to close this ticket, as these are more substantial problems than tweaking indentation.

Note: See TracTickets for help on using tickets.