WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 years ago

#43260 closed defect (bug) (worksforme)

Revision list WordPress 4.9.3 and (possibly) missing wp-includes/js/tinymce/tinymce.js in 4.9.4

Reported by: damsko Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9.4
Component: TinyMCE Keywords: close
Focuses: Cc:

Description

Not sure where to address this so i try here. If wrong place then remove.

Just been updating from WordPress 4.9.2 to 4.9.4. I used the files revised lists from 4.9.3 and 4.9.4 (i combined those lists because 4.9.3 was pulled fast and replaced with 4.9.4) to see and compare what files where updated, i noticed two things:

wp-includes/js/tinymce/tinymce.js is listed as updated on the 4.9.3 revised files list but it is not included in 4.9.4, there only is a tinymce.js.gz in wp-includes/js/tinymce/ I'm not sure if WordPress will automatically find tinymce.js.gz while looking for tinymce.js so i extracted tinymce.js.gz and uploaded tinymce.js instead.

Second thing i spotted is that the 4.9.3 revised files list has:

wp-includes/js/media/views/cropper.js
wp-includes/js/media/views/modal.js

But there is no wp-includes/js/media/views/ folder in 4.9.4 and both files are also not part of 4.9.4. There only is another cropper.js that belongs to something else as far as i can tell.

Greetings, Reiner.

Change History (2)

#1 @garrett-eclipse
2 years ago

  • Component changed from General to TinyMCE
  • Keywords close added

Hi @damsko thanks for the report.

It appears there were several changes to tinymce in 4.9.3 - https://wordpress.org/support/wordpress-version/version-4-9-3/

In 4.9.4 there was no changes to tinymce.

Doing some snooping it appears wp-tinymce.php was retired in 5.1 - https://core.trac.wordpress.org/ticket/45645
And the wp-includes/js/tinymce/wp-tinymce.js was added back and wp-includes/js/tinymce/wp-tinymce.js.gz removed in changeset - https://core.trac.wordpress.org/changeset/44654

As to the missing wp-includes/js/media/views/ folder it seems that part of the development repo and you won't see it in the regular install of WordPress. There's a discussion on this here - https://core.trac.wordpress.org/ticket/42646#comment:22

Hopefully this sheds some light on the changes. Are you still experiencing any issues with the files and changes? Going to move to the TinyMCE component and mark for closure.

#2 @azaozz
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Yes, as @garrett-eclipse points out above the changes are intended.

Closing as worksforme, feel free to reopen if something is not working right.

Note: See TracTickets for help on using tickets.