WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 4 weeks ago

#43278 closed defect (bug) (fixed)

Slug box visible on Quick Edit

Reported by: bhargavmehta Owned by: pento
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Quick/Bulk Edit Keywords: fixed-5.0
Focuses: ui, administration Cc:

Description

Steps to Reproduce:

Register a new post type with

   publicly_queryable => false


Actual Output: When we click on Quick Edit in Post in new post type Slug box is visible.

Expect Output: When we click on Quick Edit in Post in new post type Slug box should not be visible

Attachments (2)

43278.patch (787 bytes) - added by bhargavmehta 11 months ago.
Fix of the issue attached
43278.png (146.5 KB) - added by krutidugade 4 months ago.
Tested on my custom post type with the attribute publicly_queryable => false and works. The patch hides the slug for me.

Download all attachments as: .zip

Change History (17)

@bhargavmehta
11 months ago

Fix of the issue attached

#1 @SergeyBiryukov
11 months ago

  • Component changed from General to Quick/Bulk Edit

#2 @bhargavmehta
11 months ago

  • Keywords has-patch added

#3 @bhargavmehta
4 months ago

@SergeyBiryukov Any updates on this?

Thank you

This ticket was mentioned in Slack in #core by bhargavmehta. View the logs.


4 months ago

@krutidugade
4 months ago

Tested on my custom post type with the attribute publicly_queryable => false and works. The patch hides the slug for me.

#5 @bhargavmehta
4 months ago

  • Keywords has-unit-tests added

#6 @pento
4 months ago

  • Keywords has-unit-tests removed
  • Milestone changed from Awaiting Review to 5.0
  • Owner set to pento
  • Status changed from new to assigned
  • Version trunk deleted

#7 @pento
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43664:

Posts: Remove the slug from Quick Edit for CPTs with publicly_queryable disabled.

In the full edit screen, CPTs that have disabled the publicly_queryable option will hide the slug field, as it doesn't need to be edited. This change brings the Quick Edit view into line with that behaviour.

Props bhargavmehta, krutidugade.
Fixes #43278.

#8 @johnbillion
3 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[43664] should be merged into 5.0

#9 @pento
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43728:

Posts: Remove the slug from Quick Edit for CPTs with publicly_queryable disabled.

In the full edit screen, CPTs that have disabled the publicly_queryable option will hide the slug field, as it doesn't need to be edited. This change brings the Quick Edit view into line with that behaviour.

Merges [43664] to the 5.0 branch.

Props bhargavmehta, krutidugade.
Fixes #43278.

#10 @earnjam
3 months ago

@pento Pages have publicly-queryable set to false when registered too, so this makes it so you can't edit page slugs in the quick edit box. Is that intentional here or just accidental oversight?

First reported here: https://github.com/WordPress/gutenberg/issues/11277

#11 @pento
3 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for the ping, @earnjam. I'll need to think about this some more.

#12 @pento
3 months ago

In 43855:

Posts: Remove the slug from Quick Edit for posts that are not is_post_type_viewable().

This is a followup to [43728], which added the same check, but using the publicly_queryable option. This behaviour is incorrect for _builtin post types, which go by the logic in is_post_type_viewable(), instead.

See #43278.

#13 @pento
3 months ago

  • Keywords fixed-5.0 added; has-patch removed

[43855] will need to be ported to trunk later.

#14 @jeremyfelt
4 weeks ago

In 44221:

Posts: Remove the slug from Quick Edit for posts that are not is_post_type_viewable().

This is a followup to [43728], which added the same check, but using the publicly_queryable option. This behaviour is incorrect for _builtin post types, which go by the logic in is_post_type_viewable(), instead.

Merges [43855] from the 5.0 branch to trunk.

Props pento.
See #43278.

#15 @SergeyBiryukov
4 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.